Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated Image.NEAREST with Image.Resampling.NEAREST #1090

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

llwiggins
Copy link
Collaborator

@llwiggins llwiggins commented Feb 18, 2025

Really tiny change but Image.NEAREST is now deprecated and needs to be replaced with Image.Resampling.NEAREST to run without error. This is already corrected in the upcoming grains refactor but thought it was worth correcting in main in the meantime!


Before submitting a Pull Request please check the following.

  • Existing tests pass.
  • Documentation has been updated and builds. Remember to update as required...
    • docs/configuration.md
    • docs/usage.md
    • docs/data_dictionary.md
    • docs/advanced.md and new pages it should link to.
  • Pre-commit checks pass.
  • New functions/methods have typehints and docstrings.
  • New functions/methods have tests which check the intended behaviour is correct.

Optional

topostats/default_config.yaml

If adding options to topostats/default_config.yaml please ensure.

  • There is a comment adjacent to the option explaining what it is and the valid values.
  • A check is made in topostats/validation.py to ensure entries are valid.
  • Add the option to the relevant sub-parser in topostats/entry_point.py.

Copy link
Collaborator

@ns-rse ns-rse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, thanks @llwiggins for fixing this.

@llwiggins llwiggins added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit 97cf720 Feb 19, 2025
11 checks passed
@llwiggins llwiggins deleted the llwiggins/Image.NEAREST_fix branch February 19, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants