Added rough grainstats summary documentation and metric images #1087
+44
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
re-add ` `
SylviaWhittle
approved these changes
Feb 11, 2025
ns-rse
requested changes
Feb 14, 2025
There was a problem hiding this comment.
Thanks for all the hard work on this @MaxGamill-Sheffield it looks really good once rendered locally. 👍 🎨
One minor suggestion of including min_feret and max_feret in the GrainStats diagram.
There was a problem hiding this comment.
Would it be worth including min_feret and max_feret measurements here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TopoStats Pull Requests
This adds my thesis diagrams for visualisation of the metrics output by TopoStats into the documentation.
It also includes a previously missing "grainstats" section.