Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing From impl for ChatCompletionRequestMessage, replace trivial From impls with derive_more #319

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add missing From impl for ChatCompletionRequestMessage, replace trivial From impls with derive_more #319

wants to merge 1 commit into from

Conversation

grantslatton
Copy link

ChatCompletionRequestMessage didn't have From<ChatCompletionRequestDeveloperMessage>

I went to add it, and found the TODO:

// todo: write macro for bunch of same looking From trait implementations below

The crate derive_more does this by deriving From for simple wrapper-branching enums like this.

@grantslatton grantslatton mentioned this pull request Jan 13, 2025
Merged
@64bit
Copy link
Owner

64bit commented Jan 18, 2025 •
edited
Loading

Note from previous PR: #318 (review)

Please consider using derive_more::From for all Enums (or when it make sense) for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grantslatton @64bit