calculate col and row for form only if 4lbp was not specified #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miyako
changed the title
vdelachaux
reviewed
Nov 18, 2020
| @@ -121,15 +121,15 @@ If ($Boo_form) | |||
| GET PRINT OPTION:C734(Legacy printing layer option:K47:18;$legacyMode) | |||
There was a problem hiding this comment.
This is an interesting approach, but the "Legacy printing layer option" is only available on Windows. It will not solve the problem on MacOS.
There was a problem hiding this comment.
The goal is to pass a parameter to request 17R6 compatible mode. Of course, legacy printing means nothing on macOS, but we just need to read the value, we don't need to switch from Direct2D to GDI, so the solution works on both platforms. Of course there is a problem if the user really wants GDI, and it is an abuse of the specification, so a dedicated parameter would be better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the calculation of row and column count for form was incorrect.