Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚰️ Remove pluralized from assets #4025

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

josemigallas
Copy link
Contributor

@josemigallas josemigallas self-assigned this Feb 21, 2025
@mayorova
Copy link
Contributor

Looks like the only usage of the npm-imported pluralize lib is here:

{`${period.number} ${pluralize.plural(period.unit)}`}

Given that the period units is always one of: hour, day, month, maybe we can simplify this by just doing ${period.number} ${period.unit}s}` and getting rid of the library 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants