Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ルームidで管理 #18

Merged
merged 8 commits into from
Jan 24, 2021
Merged

ルームidで管理 #18

merged 8 commits into from
Jan 24, 2021

Conversation

YasuakiYoshii
Copy link
Contributor

@YasuakiYoshii YasuakiYoshii commented Jan 13, 2021 •
edited
Loading

概要

ルーム名で管理していたものをルームidで管理するよう変更．

動作確認

サーバ起動後、gosandyなどで、ws://localhost:8080/wsに接続し、"/list", "/create roomname", /join ${roomid}, "Hello"などを行う。

関連するクライアントの変更

クライアント側でルームidでルームに関する操作を行うよう変更しました．(2d-rpg/card-playroom-client#21)

issue

@YasuakiYoshii YasuakiYoshii requested a review from bana118 January 13, 2021 15:03
@YasuakiYoshii YasuakiYoshii linked an issue Jan 13, 2021 that may be closed by this pull request
websocket上でやりとりするデータ構造を決める #17
Open
@YasuakiYoshii
Copy link
Contributor Author

このPRではルーム名の被りは許されない仕様になっており，所定の要件を満たさないため閉じます．

@YasuakiYoshii YasuakiYoshii reopened this Jan 24, 2021
@YasuakiYoshii YasuakiYoshii merged commit 361b89b into develop Jan 24, 2021
@YasuakiYoshii YasuakiYoshii deleted the feature/add_room_id branch February 26, 2021 12:23
@YasuakiYoshii YasuakiYoshii mentioned this pull request May 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bana118 bana118 bana118 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

websocket上でやりとりするデータ構造を決める
2 participants
@YasuakiYoshii @bana118