Fix missing field in profile-summary when data is missing #11952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellhenke
force-pushed
the
mitchellhenke/fix-profile-summary-bug
branch
from
c932182 to
8cd32ee
Compare
changelog: Bug Fixes, Reporting, Fix missing field in profile-summary when data is missing
mitchellhenke
force-pushed
the
mitchellhenke/fix-profile-summary-bug
branch
from
8cd32ee to
66746e4
Compare
n1zyy
reviewed
Mar 5, 2025
| ['[email protected]', '[NOT FOUND]'], | ||
| ] | ||
|
|
||
| expect(result.table).to eq(expected_table) |
There was a problem hiding this comment.
I'm probably just being dense, but I don't entirely follow how these changes would have caught the previous issue. Shouldn't an equality check have failed?
There was a problem hiding this comment.
You're right, my added check does not address the issue.
There was a problem hiding this comment.
Added a hopefully clearer and more correct check in 946f8fb
mitchellhenke
force-pushed
the
mitchellhenke/fix-profile-summary-bug
branch
from
3500b6c to
946f8fb
Compare
Sgtpluck
approved these changes
Mar 6, 2025
jmax-gsa
pushed a commit
that referenced
this pull request
Mar 7, 2025
* Fix missing field in profile-summary when data is missing changelog: Bug Fixes, Reporting, Fix missing field in profile-summary when data is missing * Fix check for consistent row length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Follow up to fix a bug from #11935 where the resulting rows are missing a field in the case where a User or Profile was not found. I've also added a check to this and other table-based reports to try to avoid a regression where the row lengths do not match.