Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to only allow manual processing of our various image Features #862

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented Mar 4, 2025

Description of the Change

Right now most of our Image Processing Features automatically trigger when an image (or PDF) is uploaded. While this can be nice as it means things just magically happen without any extra effort, it does mean every single upload goes through this flow.

There's very likely a scenario where someone doesn't want an image to be processed. Also, because of the extra processing that happens (sending this image off to AI and waiting for the response), it makes the upload process slower. I could see a situation where someone wants uploads to be as fast as possible but still allow images to be manually processed after the fact (side note, there is a potential feature change we could look at where we change our image processing to fire after the image has been fully uploaded instead of blocking that process).

Similar to how we introduced a mode toggle in our Classification Feature, this PR adds in a new Processing mode setting to each of our Image Processing Features that have extra processing (all but Image Generation). This will default to Automatically on upload (which is the current behavior) but can be changed to Manually trigger, which won't process at all unless someone requests it at the individual media level.

Worth noting that you can still trigger things manually even if the mode is set to automatic.

Screenshots

New Processing mode setting

How to test the Change

  1. Check out this PR
  2. Go to the Descriptive Text Generator, Image Tags Generator, Image Cropping, Image Text Extraction or PDF Text Extraction Features
  3. Ensure the Processing mode settings shows for each and is defaulted to Automatically on upload
  4. Test each Feature to ensure it still works as expected
  5. Change the setting to be Manually trigger and test again, ensuring no processing happens until it's triggered on an individual media item

Changelog Entry

Added - New Processing Mode setting to our Image Processing Features, allowing you to only have those Features trigger when someone manually requests it, rather than automatically on upload

Credits

Props @dkotter

Checklist:

@dkotter dkotter added this to the 3.4.0 milestone Mar 4, 2025
@dkotter dkotter self-assigned this Mar 4, 2025
@dkotter dkotter requested review from jeffpaul and a team as code owners March 4, 2025 23:44
@github-actions github-actions bot added the needs:code-review This requires code review. label Mar 4, 2025
@jeffpaul
Copy link
Member

jeffpaul commented Mar 5, 2025

side note, there is a potential feature change we could look at where we change our image processing to fire after the image has been fully uploaded instead of blocking that process

This feels like a worthwhile update, perhaps as an additional option for Processing mode of "Automatic after upload" with the current default iterating to "Automatic during upload" perhaps?

@jeffpaul jeffpaul requested review from iamdharmesh and removed request for a team March 5, 2025 15:27
@dkotter
Copy link
Collaborator Author

dkotter commented Mar 5, 2025

This feels like a worthwhile update, perhaps as an additional option for Processing mode of "Automatic after upload" with the current default iterating to "Automatic during upload" perhaps?

I agree, this would definitely be a nice follow up enhancement here. I do think some thought will need to be put into the UX in this scenario though. For instance, if we send off the image for processing async, very likely someone may upload an image and then click in to edit the image and no alt text (or description or tags, etc) will have returned yet. Seems like we should at least show a message letting them know processing is happening. Potentially even preventing updates until processing is finished (i.e. disable the alt input)?

@jeffpaul
Copy link
Member

jeffpaul commented Mar 7, 2025

FYI I created #863 to try and provide an option for follow-up after this feature lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
Status: Code Review
Development

Successfully merging this pull request may close these issues.

2 participants