-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to only allow manual processing of our various image Features #862
base: develop
Are you sure you want to change the base?
Conversation
…u to choose how images are processed
This feels like a worthwhile update, perhaps as an additional option for Processing mode of "Automatic after upload" with the current default iterating to "Automatic during upload" perhaps? |
I agree, this would definitely be a nice follow up enhancement here. I do think some thought will need to be put into the UX in this scenario though. For instance, if we send off the image for processing async, very likely someone may upload an image and then click in to edit the image and no alt text (or description or tags, etc) will have returned yet. Seems like we should at least show a message letting them know processing is happening. Potentially even preventing updates until processing is finished (i.e. disable the alt input)? |
FYI I created #863 to try and provide an option for follow-up after this feature lands. |
Description of the Change
Right now most of our Image Processing Features automatically trigger when an image (or PDF) is uploaded. While this can be nice as it means things just magically happen without any extra effort, it does mean every single upload goes through this flow.
There's very likely a scenario where someone doesn't want an image to be processed. Also, because of the extra processing that happens (sending this image off to AI and waiting for the response), it makes the upload process slower. I could see a situation where someone wants uploads to be as fast as possible but still allow images to be manually processed after the fact (side note, there is a potential feature change we could look at where we change our image processing to fire after the image has been fully uploaded instead of blocking that process).
Similar to how we introduced a mode toggle in our Classification Feature, this PR adds in a new
Processing mode
setting to each of ourImage Processing
Features that have extra processing (all butImage Generation
). This will default toAutomatically on upload
(which is the current behavior) but can be changed toManually trigger
, which won't process at all unless someone requests it at the individual media level.Worth noting that you can still trigger things manually even if the mode is set to automatic.
Screenshots
How to test the Change
Descriptive Text Generator
,Image Tags Generator
,Image Cropping
,Image Text Extraction
orPDF Text Extraction
FeaturesProcessing mode
settings shows for each and is defaulted toAutomatically on upload
Manually trigger
and test again, ensuring no processing happens until it's triggered on an individual media itemChangelog Entry
Credits
Props @dkotter
Checklist: