Add Geo Location Feature #123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burhandodhy
force-pushed
the
feature/92
branch
from
bf466fa to
17d2c6c
Compare
felipeelia
reviewed
Mar 6, 2025
Comment on lines
+2
to
+4
| --ep-c-medium-red: #d73c38; | ||
|
|
||
| color: var(--ep-c-medium-red); |
There was a problem hiding this comment.
@burhandodhy can't we use any of the already existent EP colors?
felipeelia
reviewed
Mar 6, 2025
| public function set_i18n_strings(): void { | ||
| $this->title = esc_html__( 'Geo Location', 'elasticpress-labs' ); | ||
|
|
||
| $this->summary = '<p>' . __( 'Geo Location feature allows you to search for posts based on their location.', 'elasticpress-labs' ) . '</p>'; |
There was a problem hiding this comment.
Suggested change
| $this->summary = '<p>' . __( 'Geo Location feature allows you to search for posts based on their location.', 'elasticpress-labs' ) . '</p>'; | |
| $this->summary = '<p>' . __( 'Allow users to search for posts based on their location.', 'elasticpress-labs' ) . '</p>'; |
felipeelia
reviewed
Mar 6, 2025
Comment on lines
+96
to
+97
| 'has_map_key' => ! empty( $google_maps_api_key ), | ||
| 'is_external_meta' => has_filter( 'ep_geo_location_pre_geo_points' ), |
There was a problem hiding this comment.
As these will be used in JS, can we use camelCase here, please?
felipeelia
reviewed
Mar 6, 2025
| * @return array Mapping. | ||
| */ | ||
| public function add_mapping( $mapping ): array { | ||
| $mapping['mappings']['properties']['geo_point'] = [ |
There was a problem hiding this comment.
@burhandodhy this will only work on ES 7+. If geo_point is not available on ES 5.2 we should not allow people to activate it. If it is, we'll need something like
if ( version_compare( (string) Elasticsearch::factory()->get_elasticsearch_version(), '7.0', '<' ) ) {
$mapping_properties = &$mapping['mappings']['post']['properties'];
} else {
$mapping_properties = &$mapping['mappings']['properties'];
}
$mapping_properties['geo_point'] = [
felipeelia
reviewed
Mar 6, 2025
| * @return FeatureRequirementsStatus | ||
| */ | ||
| public function requirements_status() { | ||
| /** Features Class @var Features $features */ |
There was a problem hiding this comment.
Is the purpose of this line to help with autocomplete?
felipeelia
reviewed
Mar 6, 2025
| */ | ||
| protected function process_geo_distance_sort( $sort, $args ): array { | ||
| foreach ( $sort as $key => &$sort_item ) { | ||
| if ( isset( $sort_item['geo_distance'] ) ) { |
There was a problem hiding this comment.
Mind sharing the rationale behind this renaming?
felipeelia
requested changes
Mar 6, 2025
There was a problem hiding this comment.
Overall it is looking really really good, @burhandodhy! We are almost there!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR adds a new feature Geo Location
Closes #92
How to test the Change
Changelog Entry
Credits
Props @burhandodhy @felipeelia
Checklist: