chore: Adding Core unit tests #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncancmt
approved these changes
Jan 19, 2024
Comment on lines
+119
to
+120
| // Broken usage of OtcOrderSettlement.OtcOrderFilled in 0.8.21 | ||
| // https://github.com/foundry-rs/foundry/issues/6206 |
There was a problem hiding this comment.
Glad to see that this is fixed in 0.8.22. There's a bunch of places in this codebase and others where I ought to refactor
Comment on lines
+44
to
+48
| _mockExpectCall( | ||
| address(TOKEN), | ||
| abi.encodeWithSelector(IERC20.allowance.selector, address(basic), address(POOL)), | ||
| abi.encode(amount) | ||
| ); |
There was a problem hiding this comment.
I wish there was a way to do this in a "ask forgiveness, not permission" way. it seems so wasteful
There was a problem hiding this comment.
I'm on the fence, we could make it a default success dummy (instead of rejection dummy), but we do want to test that it checks the allowance, and we do want to test that when the allowance isn't set, that it does set the approval. At least in a few tests.
I don't entirely mind repeating ourselves here for the time being.
duncancmt
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.