Bug! spurious Transfer events

0xProject · Jan 8, 2024 · 9c84ac5 · 9c84ac5
1 parent d4b5402
commit 9c84ac5
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/src/deployer/Deployer.sol b/src/deployer/Deployer.sol
@@ -180,17 +180,15 @@ contract Deployer is TwoStepOwnable, IERC721ViewMetadata {
         if (next == 0) {
             // assert(_featureNonce[feature] == nonce);
             _featureNonce[feature] = prev;
-        } else {
-            _deploymentLists[next].prev = prev;
-        }
-        if (prev == 0) {
-            emit Transfer(AddressDerivation.deriveContract(address(this), nonce), address(0), feature);
-        } else {
             emit Transfer(
                 AddressDerivation.deriveContract(address(this), nonce),
-                AddressDerivation.deriveContract(address(this), prev),
+                prev == 0 ? address(0) : AddressDerivation.deriveContract(address(this), prev),
                 feature
             );
+        } else {
+            _deploymentLists[next].prev = prev;
+        }
+        if (prev != 0) {
             _deploymentLists[prev].next = next;
         }
         delete entry.prev;