Route direction in Zniffer appears to be backwards

[kpine]

Checklist

• I am not using Home Assistant. Or: a developer has told me to come here.
• I have checked the troubleshooting section and my problem is not described there.
• I have read the changelog and my problem is not mentioned there.

Deploy method

PKG executable

Z-Wave JS UI version

9.29.1

ZwaveJS version

14.3.7

Describe the bug

In the Zniffer pane the route direction is backwards.

To Reproduce

Make a zniffer trace.

Expected behavior

The route direction is displayed correctly.

Additional context

Here's a screenshot with a Meter Report highlighted. The route direction indicates a message from the controller (1) to the end device (64). But in reality the node has sent the message, so the direction should be 1 ← 64 or 64 → 1.

In comparison, the SiLabs Zniffer application indicates the source node as 64 and the destination as 1, without a Routed indication as it is direct.

[robertsLando]

I think the issue here is that the arrow should always be like '→' because later we sort nodeIds starting from sender to receiver based on the direction. This is the method I use:

zwave-js-ui/src/lib/utils.js

Lines 226 to 272 in 46a9eda

	export function getRoute(item, withRssi = false) {
	if (item.corrupted) {
	return ''
	}
	const repRSSI = item.repeaterRSSI || []
	const dir = item.direction === 'inbound' ? '←' : '→'
	const hop = item.hop !== undefined ? item.hop : -1
	const route = [
	item.direction === 'outbound'
	? item.sourceNodeId
	: item.destinationNodeId,
	...(item.repeaters || []),
	item.direction === 'outbound'
	? item.destinationNodeId
	: item.sourceNodeId,
	].map(
	(r, i) =>
	`${r}${
	withRssi && repRSSI[i - 1] && !isRssiError(repRSSI[i - 1])
	? ` (${rssiToString(repRSSI[i - 1])})`
	: ''
	}`,
	)
	let routeString = ''
	if (hop >= 0) {
	// highlight the hop
	for (let i = 0; i < route.length; i++) {
	routeString += route[i]
	if (i < route.length - 1) {
	if (i === item.failedHop) {
	routeString += ' ! '
	} else {
	routeString += ` ${
	hop === i ? '<b class="text-decoration-underline">' : ''
	}${dir}${hop === i ? '</b>' : ''} `
	}
	}
	}
	} else {
	routeString = route.join(` ${dir} `)
	}
	return routeString
	}

So making const dir = '→' should fix the issue IMO. @AlCalzone any clue? Maybe SiLabs Zniffer uses a different approach?

[AlCalzone]

@kpine can you verify if only 0-hop routes have their direction wrong? The code above looks like they may.
I'm not 100% sure what the intention was, but I think I wanted "request" frames to point right, and "response" frames to point left. However that logic conflicts with the conditional position of the source and destination in the route array.

[kpine]

I think you are correct, I turned on a light switch remotely and here is the result:

Set/Get and Report are in the correct direction, in this case the source is on the left side.

[AlCalzone]

Ok, I think this is purely a UI issue then. Let's keep both open until I've verified.