Skip to content

Commit bf7f923

Browse files
refactor: Change name of update_recipients function.
Change the name of update_recipients to update_recipients_from_emails_in_widget.
1 parent aa48f18 commit bf7f923

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

Diff for: tests/ui_tools/test_boxes.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -408,7 +408,7 @@ def test_footer_notification_on_invalid_recipients(
408408
),
409409
],
410410
)
411-
def test_update_recipients(
411+
def test_update_recipients_from_emails_in_widget(
412412
self,
413413
write_box: WriteBox,
414414
header: str,
@@ -419,7 +419,7 @@ def test_update_recipients(
419419
assert write_box.to_write_box is not None
420420
write_box.to_write_box.edit_text = header
421421

422-
write_box.update_recipients(write_box.to_write_box)
422+
write_box.update_recipients_from_emails_in_widget(write_box.to_write_box)
423423

424424
assert write_box.recipient_emails == expected_recipient_emails
425425
assert write_box.recipient_user_ids == expected_recipient_user_ids

Diff for: zulipterminal/ui_tools/boxes.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ def track_idleness_and_update_status() -> None:
280280

281281
urwid.connect_signal(self.msg_write_box, "change", on_type_send_status)
282282

283-
def update_recipients(self, write_box: ReadlineEdit) -> None:
283+
def update_recipients_from_emails_in_widget(self, write_box: ReadlineEdit) -> None:
284284
self.recipient_emails = re.findall(REGEX_RECIPIENT_EMAIL, write_box.edit_text)
285285
self._set_regular_and_typing_recipient_user_ids(
286286
[self.model.user_dict[email]["user_id"] for email in self.recipient_emails]
@@ -776,7 +776,7 @@ def keypress(self, size: urwid_Size, key: str) -> Optional[str]:
776776
)
777777
if not all_valid:
778778
return key
779-
self.update_recipients(self.to_write_box)
779+
self.update_recipients_from_emails_in_widget(self.to_write_box)
780780
if self.recipient_user_ids:
781781
success = self.model.send_private_message(
782782
recipients=self.recipient_user_ids,
@@ -830,7 +830,7 @@ def keypress(self, size: urwid_Size, key: str) -> Optional[str]:
830830
)
831831
if not all_valid:
832832
return key
833-
self.update_recipients(self.to_write_box)
833+
self.update_recipients_from_emails_in_widget(self.to_write_box)
834834
this_draft: Composition = PrivateComposition(
835835
type="private",
836836
to=self.recipient_user_ids,
@@ -905,7 +905,7 @@ def keypress(self, size: urwid_Size, key: str) -> Optional[str]:
905905
# We extract recipients' user_ids and emails only once we know
906906
# that all the recipients are valid, to avoid including any
907907
# invalid ones.
908-
self.update_recipients(self.to_write_box)
908+
self.update_recipients_from_emails_in_widget(self.to_write_box)
909909

910910
if not self.msg_body_edit_enabled:
911911
return key

0 commit comments

Comments
 (0)