Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "(no topic)" to "general chat" #5838

Closed
alya opened this issue Mar 6, 2024 · 6 comments
Closed

Rename "(no topic)" to "general chat" #5838

alya opened this issue Mar 6, 2024 · 6 comments
Labels
P1 high-priority server release goal Things we should try to coordinate with a major Zulip Server release. webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity.

Comments

@alya
Copy link
Collaborator

alya commented Mar 6, 2024

In zulip/zulip#23291, we plan to rename "(no topic)" to "general chat". This is expected to require some work to support on mobile, but the details of that are TBD pending design decisions that have not been finalized yet.

References

@alya alya added the webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity. label Mar 6, 2024
@mayankdhangar2408

This comment was marked as spam.

@gnprice

This comment was marked as off-topic.

@kartik-212004

This comment was marked as outdated.

@chrisbobbe

This comment was marked as outdated.

@gnprice gnprice added server release goal Things we should try to coordinate with a major Zulip Server release. P1 high-priority labels Jan 8, 2025
@gnprice
Copy link
Member

gnprice commented Jan 9, 2025

This feature appears to be landing in the upcoming Zulip Server 10, and will be one of the headline features there. So it'll be one of the few features we build for this legacy app.

I think the plan I'd like to pursue is to develop the feature first in zulip-flutter (zulip/zulip-flutter#1250), because development is more efficient in the Flutter app. Then when we've worked out all the questions there about what's involved and how the feature should work, we can port the changes over to this codebase.

This remains a task for the core team; we aren't able to spend time helping people work with the legacy codebase. For anyone interested in contributing to Zulip, see the zulip-flutter repo's README and Zulip's guide to contributing:
https://zulip.readthedocs.io/en/latest/contributing/contributing.html

@gnprice
Copy link
Member

gnprice commented Feb 21, 2025

A few weeks ago we decided to skip building the Zulip Server 10 features for this legacy app. We're proceeding with implementing them in the new Flutter-based app (e.g. zulip/zulip-flutter#1250 for this "general chat" feature), and so the way they reach users will be that we launch that new app in the next couple of months.

For this particular feature, it's changing how a core part of the Zulip model works (topics!), and so the compatibility story for existing clients is fairly complex. We did spend significant effort on designing a compatibility plan we expect to work — see the #api design thread — but I wanted to also validate empirically that when the existing client interacts with the feature, the UX is reasonable and things don't break.

The feature is now deployed on chat.zulip.org, and there are some threads there using it. So I just spent a few minutes using the app with those. As far as I saw, everything is fine — our compatibility plan worked.

Specifically, I tried:

  • seeing a "test general chat" thread in the inbox
  • seeing it amongst other threads in a channel narrow
  • seeing it in the topic-list screen for a channel
  • viewing it in a conversation narrow
  • replying to it

Everything worked fine, just as if it were a normal thread with the name "test general chat". (Which is the value of realm_empty_topic_display_name that chat.zulip.org currently has, while the feature is experimental.)

So I think there's nothing more we need to do for this feature in the legacy app.

@gnprice gnprice closed this as not planned Won't fix, can't repro, duplicate, stale Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 high-priority server release goal Things we should try to coordinate with a major Zulip Server release. webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity.
Projects
Status: Done
Development

No branches or pull requests

5 participants