Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate finding a GIF to add to a message #418

Open
gnprice opened this issue Nov 27, 2023 · 4 comments
Open

Integrate finding a GIF to add to a message #418

gnprice opened this issue Nov 27, 2023 · 4 comments
Labels
a-compose Compose box, autocomplete, attaching files/images
Milestone

Comments

@gnprice
Copy link
Member

gnprice commented Nov 27, 2023

Feature request here:

GIFs are a beloved feature that it would be awesome to see equally integrated in all of the platforms.

I.e., this Zulip feature:
https://zulip.com/help/animated-gifs-from-giphy

This may be a bit complicated to implement, and it's a feature we don't have in zulip-mobile so it's for after launch. But users who enjoy that Zulip feature will appreciate having it on mobile.

@gnprice gnprice added the a-compose Compose box, autocomplete, attaching files/images label Nov 27, 2023
@gnprice gnprice added this to the Post-launch milestone Nov 27, 2023
@Sahil-kachhap
Copy link

  • @gnprice are we supposed to show a preview of the gif/image in the textfield itself or just send the selected gif in the chat.
  • I think both of these listed feature requests (support for gif and image from keyboard can be compiled in a single issue).
  • I have been spending some time on this, the following snippet allows us to add these support:
   TextField(
        contentInsertionConfiguration: ContentInsertionConfiguration(
         onContentInserted: (data){
                   // process selected gif/image
          },
          allowedMimeTypes: const <String>['image/png', 'image/gif'],
       ),
    );

@gnprice
Copy link
Member Author

gnprice commented Feb 25, 2024

The main goal is to have the image appear in the message that the user eventually sends, in the same way as other images currently do in Zulip messages.

Having it appear in the text field while the message is still being composed would be an interesting bonus feature, but I expect it will be complicated to make that work well in a way that fits smoothly with how Zulip messages are represented in the Zulip API, as Zulip Markdown. So it'd be a good idea to separate out anything like that into a separate commit or commits at the end of the PR, to make it possible to merge the main feature without that part.

Note that this issue has the "Post-launch" milestone, which means it's not something the core team would expect to get to ourselves until at least late this year, after this app is ready to replace the RN-based zulip-mobile app. We'll still take PRs for such issues, but for these it'll be extra important that the PRs be clean and easy to review:
https://zulip.readthedocs.io/en/latest/contributing/commit-discipline.html

@Syrineladeb02
Copy link

If this issue is available, I'd like to work on it.

@gnprice
Copy link
Member Author

gnprice commented Apr 1, 2024

@Syrineladeb02 Please see our guide to picking an issue to work on:
https://github.com/zulip/zulip-flutter#picking-an-issue-to-work-on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-compose Compose box, autocomplete, attaching files/images
Projects
Status: No status
Development

No branches or pull requests

3 participants