Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msglist: Move star icon 2px away from the edge of the screen #1247

Closed
chrisbobbe opened this issue Jan 2, 2025 · 4 comments · Fixed by #1249
Closed

msglist: Move star icon 2px away from the edge of the screen #1247

chrisbobbe opened this issue Jan 2, 2025 · 4 comments · Fixed by #1249
Assignees
@lakshya1goel
Labels
a-msglist The message-list screen, except what's label:a-content beta feedback Things beta users have specifically asked for help wanted
Milestone
M5-a: Server 10

Comments

@chrisbobbe
Copy link
Collaborator

We've had some reactions in beta feedback that the star icon is too close to the edge of the screen:

We've decided (see linked discussion) to move the star 2px inward while leaving the message-content margin unchanged (16px). This means there might be some overlap between the text and the star, but that seems rare and probably not critical. (We can think more about this if we do get reports that it's a problem.)
@chrisbobbe chrisbobbe added a-msglist The message-list screen, except what's label:a-content beta feedback Things beta users have specifically asked for labels Jan 2, 2025
@chrisbobbe chrisbobbe added this to the M6: Post-launch milestone Jan 2, 2025
@chrisbobbe
Copy link
Collaborator Author

For the implementation, perhaps we want a Stack with a Positioned child.

@lakshya1goel
Copy link
Contributor

Hi, I want to work on this issue.

lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Jan 3, 2025
@lakshya1goel
msglist: Move star icon 2px away from the edge of the screen
ca079f2 
Fixes: zulip#1247
@lakshya1goel lakshya1goel mentioned this issue Jan 3, 2025
Merged
@lakshya1goel
Copy link
Contributor

Hey, I have raised a PR for this issue please review it.
Thanks!

@yashrajpu
Copy link

Please assign this issue to me. I have already solved it, I just need to commit the changes. Thank you!

lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Jan 27, 2025
@lakshya1goel
msglist: Move star icon 2px away from the edge of the screen
e1689ec 
Fixes: zulip#1247
lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Jan 29, 2025
@lakshya1goel
msglist: Move star icon 2px away from the edge of the screen
92acf67 
Fixes: zulip#1247
lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Feb 11, 2025
@lakshya1goel
msglist: Move star icon 2px away from the edge of the screen
1098e35 
Fixes: zulip#1247
lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Feb 13, 2025
@lakshya1goel
msglist: Move star icon 2px away from the edge of the screen
6ccc289 
Fixes: zulip#1247
lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Feb 13, 2025
@lakshya1goel
msglist: Move star icon 2px away from the edge of the screen
d5a25e6 
Fixes: zulip#1247
lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Feb 14, 2025
@lakshya1goel
msglist: Move star icon 2px away from the edge of the screen
c4229d1 
Fixes: zulip#1247
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lakshya1goel lakshya1goel

Labels
a-msglist The message-list screen, except what's label:a-content beta feedback Things beta users have specifically asked for help wanted
Projects
Flutter app
Status: Done
Milestone
M5-a: Server 10
Development

Successfully merging a pull request may close this issue.

msglist: Move star icon 2px away from the edge of the screen lakshya1goel/zulip-flutter
4 participants
@gnprice @chrisbobbe @lakshya1goel @yashrajpu