Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

login: When requireEmailFormatUsernames, check client-side that username looks like an email address #106

Open
chrisbobbe opened this issue May 23, 2023 · 2 comments
Labels
Milestone

Comments

@chrisbobbe
Copy link
Collaborator

It's nice to avoid a round-trip to the server when we can tell the user what's wrong and how to fix it.

@davidodejobi
Copy link

davidodejobi commented Mar 16, 2024

Hi @chrisbobbe,

I've been digging into the codebase and still getting familiar with it. Could you assign this task to me, so I can start diving in and contributing?

After reviewing the issue and looking at the codebase, I'm planning to implement an additional validation if the requireEmailFormatUsernames is true. This will involve adding localization for a message prompting users to input a valid email if the format is incorrect.

@chrisbobbe
Copy link
Collaborator Author

Hi @davidodejobi, welcome! Could you describe the validation you have in mind? Please explain what a valid email address is and how you would like to check if the input is one.

@gnprice gnprice modified the milestones: Launch, Post-launch Jul 31, 2024
@gnprice gnprice modified the milestones: M6: Post-launch, M7: Future Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

3 participants