Skip to content

Commit 6619177

Browse files
committed
Revert logUpload and logDownload to include filenames, because they come from storageFileItems and not from storageFiles where we want to eliminate them
1 parent 0d6b96b commit 6619177

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

model/Storage.inc.php

+8-5
Original file line numberDiff line numberDiff line change
@@ -183,18 +183,20 @@ public static function logDownload($item, $downloadUserID, $ipAddress) {
183183

184184
$info = self::getLocalFileItemInfo($item);
185185
$storageFileID = $info['storageFileID'];
186+
$filename = $info['filename'];
186187
$size = $info['size'];
187188

188189
$sql = "INSERT INTO storageDownloadLog
189-
(ownerUserID, downloadUserID, ipAddress, storageFileID, size)
190-
VALUES (?, ?, INET_ATON(?), ?, ?)";
190+
(ownerUserID, downloadUserID, ipAddress, storageFileID, filename, size)
191+
VALUES (?, ?, INET_ATON(?), ?, ?, ?)";
191192
Zotero_DB::query(
192193
$sql,
193194
[
194195
$ownerUserID,
195196
$downloadUserID,
196197
$ipAddress,
197198
$storageFileID,
199+
$filename,
198200
$size
199201
],
200202
0,
@@ -284,15 +286,16 @@ public static function logUpload($uploadUserID, $item, $key, $ipAddress) {
284286

285287
$info = self::getLocalFileItemInfo($item);
286288
$storageFileID = $info['storageFileID'];
289+
$filename = $info['filename'];
287290
$size = $info['size'];
288291

289292
$sql = "DELETE FROM storageUploadQueue WHERE uploadKey=?";
290293
Zotero_DB::query($sql, $key);
291294

292295
$sql = "INSERT INTO storageUploadLog
293-
(ownerUserID, uploadUserID, ipAddress, storageFileID, size)
294-
VALUES (?, ?, INET_ATON(?), ?, ?)";
295-
Zotero_DB::query($sql, array($ownerUserID, $uploadUserID, $ipAddress, $storageFileID, $size));
296+
(ownerUserID, uploadUserID, ipAddress, storageFileID, filename, size)
297+
VALUES (?, ?, INET_ATON(?), ?, ?, ?)";
298+
Zotero_DB::query($sql, array($ownerUserID, $uploadUserID, $ipAddress, $storageFileID, $filename, $size));
296299
}
297300

298301

0 commit comments

Comments
 (0)