Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem when having multiple jbot registrations for one file #2

Open
vangheem opened this issue Jun 24, 2014 · 3 comments
Open

problem when having multiple jbot registrations for one file #2

vangheem opened this issue Jun 24, 2014 · 3 comments

Comments

@vangheem
Copy link
Member

if multiple jbot customizations are registered that customize the same file, it seems the customization is alternated.

The problem lies in the use of yield in utility.getManagers. Building and returning a list of managers fixes the problem at some performance impact I expect.

Could we cache the getManagers call on the request?

@vangheem
Copy link
Member Author

This pull request addresses the issue: #3

@cekk
Copy link

cekk commented Oct 5, 2016

@vangheem i know that this is a very old issue, but i think i have a similar problem with a viewlet (footer.pt) overrided two times (in a base theme and in a secondary theme)

On development environment i never had problems, but on production (with 4 instances), sometimes i see that one (random) instance loads a different viewlet (sometimes one of the two customizations, and sometimes the original viewlet).

Any news about your PR? Can i use your fixes anyway?

@vangheem
Copy link
Member Author

vangheem commented Oct 6, 2016

yah, hmmm, I must not have experienced it again so I never pushed getting this merged. My PR is fine and caches the call on the request object. I don't see any reason it shouldn't be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants