Replies: 9 comments 21 replies
-
Firstly, thank you Michael for collaborating with me to get #387 merged! In response to this discussion:
|
Beta Was this translation helpful? Give feedback.
-
Awesome that the page is back up! I'm wondering though, perhaps it's a better long term plan to have a separate repo for the zk website and docs? The benefits then are:
I've experienced these benefits while contributing to the docs site for actual budget I'm also happy to take on the job of transitioning the documentation from the zk and zk-nvim repos to a zk-docs repo 🤚 |
Beta Was this translation helpful? Give feedback.
-
Really dig this design aesthetic for a docs site: https://dlvhdr.github.io/gh-dash/ If people come across any other inspirations / designs / examples, post as replies within this comment :) |
Beta Was this translation helpful? Give feedback.
-
@zk-org/maintainers Hugo is seeming a bit overkill for our purposes imo. Mkdocs provides a much simpler and cleaner to manage. It has a static sidebar by default (that scrolls out of view when you scroll down the page), but I was playing last night and implemented it as a sticky scrollbar (and made a pr, maybe they accept it). But worst case we could just manage our own fork of the implementation (if we like the theme in the first place)? Cool thing is that it also has a sans font setting: https://ntno.github.io/mkdocs-terminal/configuration/palettes/sans-dark/ Otherwise, with monospace font: https://ntno.github.io/mkdocs-terminal/configuration/palettes/dark/ So, I'm thinking that if others also dig the terminal theme (monospace or not), we should probably go with that, just to keep things simple for now. There's not so much overhead for implementation of this, so if we find it's not cutting it down the track then we can scale up to something more beefy like a fully fledged like hugo / astro / 11ty / etc. There is also still the material for mkdocs implementation and base theme, which is pretty nice. But doesn't have the same minimal / crisp / stripped back design that MkDocs also has built in static search box functionality out of the box too, which is really nice. Thoughts? |
Beta Was this translation helpful? Give feedback.
-
First play around (source code if peeps are interested). There's a bit of hackery going on, as Sphinx is based on Myst also allows the injection of :::{note}
This will be rendered as a callout box.
::: The current documentation we have has effectively worked seemlessly by copying them and the assets straight into the sphinx project. One thing is the Removing the div images allows them to render, and because it's an actual static site, we have css, and Sphinx has a img {
max-width: 85%;
display: block;
margin-left: auto;
margin-right: auto;
} So, that is one niggle, but otherwise we wouldn't need to change anything to get the docs site up. And we are barely using images, or need to rely on them too much. So it's not much overhead to get the images working at all. I'll go through the paces of doing the same setup with One thing is it doesn't seem to have very good options for controlling how the items in the main side bar are generated. eg (same pages as above, but with It's both a nice and annoying feature. It's fast for a user to navigate, but with a fair amount of documentation, the sidebar becomes suuuuper long... Anyway, lets see 👍 |
Beta Was this translation helpful? Give feedback.
-
So, had a bit of a play around with MkDocs. The two are really very similar, which is not a huge surprise. More of a surprise that Sphinx is still going strong considering how old it is and how new MkDocs is. But I guess, there really isn't too much extra spice to bring to static markdown documentation builders 🤷♂️ And so I reckon we go with Sphinx for these main reasons:
The only real potential snag I see is that markdown support has been patched on top by implementing the Myst parser. But that happened a few years ago, and it's seemingly super robust. I'm sure they did this out of necessity to stay relevant and compete with mkdocs, docusaurus, etc. AND, I just found a very nice theme called, Furo, perhaps not as "crisp" out of the box, but it can for sure be made more crispy with a few tweaks (builtin user options and/or css tweaks). Hide some border lines, colours, etc. But it has:
@mickael-menu , at this point I'd ping you and check back in, as my inclination is that the others will be happy with this choice (framework wise and also theme, as it's not such a huge departure from what we already felt was a good layout / design). Is it a go for you? |
Beta Was this translation helpful? Give feedback.
-
Went a little quite here, so I've pressed ahead with the direction mentioned above. Tracking here in this repo for now: https://github.com/zk-org/docs |
Beta Was this translation helpful? Give feedback.
-
@zk-org/maintainers Alrighty, first working docs site is up 🥳: https://zk-org.github.io/docs/ The docs are also set up as a Main question then is whether to keep the docs as a separate repo or not? Pro:
Cons:
Otherwise, any immediate issues / dislikes that I should fix? If not, and once we decide on mono-docs repo or not, I can finally put this task to rest! |
Beta Was this translation helpful? Give feedback.
-
Completed with #453 : https://zk-org.github.io/zk/ Bit messy... but got there in the end. |
Beta Was this translation helpful? Give feedback.
-
Our documentation is now hosted on github pages, thanks to @hugginsio via #387
Check it out: https://zk-org.github.io/zk/
A few things we should consider now:
I already went ahead and added it as the repository's "website":
Add a link to the top of the README?
Replace the links in the README?
zk/.github/workflows/gh-pages.yml
Line 6 in 1471c6b
Link it at each release, in the release?
Beta Was this translation helpful? Give feedback.
All reactions