fix guard for non-symlinked plugins

also remove the need for Guardfile within plugins (and stop including
them)

note that guard still can't detect changes to files in symlinked plugins
on the mac (due to fsevent), though you can hit enter to recompile everything

test plan:
1. clone a plugin into vendor/plugins
2. start up guard
3. edit a coffee file in the plugin
4. guard should detect it and compile it in the right place
5. edit a coffee spec file in the plugin
6. guard should detect it and compile it in the right place
7. edit a handlebars file in the plugin
8. guard should detect it and compile it in the right place
9. hit enter
10. guard should compile all coffee/handlebars files in the right place

Change-Id: I1e7c12f1368af66dee024e258899412526bb3fd2
Reviewed-on: https://gerrit.instructure.com/20219
Tested-by: Jenkins <[email protected]>
Reviewed-by: Ryan Florence <[email protected]>
Product-Review: Jon Jensen <[email protected]>
QA-Review: Jon Jensen <[email protected]>

Author: jenseng

Gemfile

@@ -121,7 +121,7 @@ group :test do
 end
 
 group :development do
-  gem 'guard', '1.6.0'
+  gem 'guard', '1.8.0'
   gem 'rb-inotify', '~>0.9.0', :require => false
   gem 'rb-fsevent', :require => false
   gem 'rb-fchange', :require => false

Guardfile

@@ -1,12 +1,11 @@
 $LOAD_PATH << File.dirname(__FILE__)
 
+ignore! Listen::DirectoryRecord::DEFAULT_IGNORED_DIRECTORIES - ['vendor'] + [%r{vendor/(?!plugins)}]
+
 guard 'coffeescript', :input => 'app/coffeescripts',  :output => 'public/javascripts/compiled'
 guard 'coffeescript', :input => 'spec/coffeescripts', :output => 'spec/javascripts'
+guard 'coffeescript', :input => 'spec_canvas/coffeescripts', :output => 'spec_canvas/javascripts'
 guard 'jst',          :input => 'app/views/jst',      :output => 'public/javascripts/jst'
 guard :styleguide
 guard :js_extensions
 
-Dir[File.join(File.dirname(__FILE__),'vendor/plugins/*/Guardfile')].each do |g|
-  eval(File.read(g))
-end
-

guard/coffeescript.rb

@@ -47,7 +47,9 @@ class << self
 
         def run(files, watchers, options = { })
           notify_start(files, options)
-          changed_files, errors = compile_files(files, watchers, options)
+          changed_files, errors = partition_by_plugin(files) do |prefix, plugin_files|
+            compile_files(plugin_files, watchers, options.merge(:output => "#{prefix}#{options[:output]}"))
+          end
           notify_result(changed_files, errors, options)
 
           [changed_files, errors.empty?]
@@ -58,6 +60,20 @@ def run(files, watchers, options = { })
 
         private
 
+        def partition_by_plugin(files, &block)
+          groupings = files.inject({}) { |hash, file|
+            prefix = file =~ %r{\Avendor/plugins/.*?/} ? $& : ''
+            hash[prefix] ||= []
+            hash[prefix] << file
+            hash
+          }
+          groupings.map(&block).inject([[], []]) { |ary, ret|
+            ary[0].concat ret[0]
+            ary[1].concat ret[1]
+            ary
+          }
+        end
+
         def notify_start(files, options)
           message = options[:message] || (options[:noop] ? 'Verify ' : 'Compile ') + files.join(', ')
           Formatter.info(message, :reset => true)
@@ -167,7 +183,7 @@ def initialize(watchers = [], options = {})
 
       if options[:input]
         defaults.merge!({ :output => options[:input] })
-        watchers << ::Guard::Watcher.new(%r{^#{ options.delete(:input) }/(.+\.coffee)$})
+        watchers << ::Guard::Watcher.new(%r{\A(?:vendor/plugins/.*?/)?#{ Regexp.escape(options.delete(:input)) }/(.+\.coffee)\z})
       end
 
       super(watchers, defaults.merge(options))

guard/jst.rb

@@ -27,7 +27,7 @@ def initialize(watchers = [], options = {})
 
       if options[:input]
         defaults.merge!({ :output => options[:input] })
-        watchers << ::Guard::Watcher.new(%r{^#{ options[:input] }/(.+\.handlebars)$})
+        watchers << ::Guard::Watcher.new(%r{\A(?:vendor/plugins/.*?/)?#{ Regexp.escape(options[:input]) }/(.+\.handlebars)\z})
       end
 
       super(watchers, defaults.merge(options))
@@ -49,10 +49,14 @@ def start
     #
     # Compiles templates from app/views/jst to public/javascripts/jst
     def run_on_change(paths)
-      Parallel.each(paths, :in_threads => Parallel.processor_count) do |path|
+      paths = paths.map{ |path|
+        prefix = path =~ %r{\Avendor/plugins/.*?/} ? $& : ''
+        [prefix, path]
+      }
+      Parallel.each(paths, :in_threads => Parallel.processor_count) do |prefix, path|
         begin
           UI.info "Compiling: #{path}"
-          Handlebars.compile_file path, 'app/views/jst', @options[:output]
+          Handlebars.compile_file path, "#{prefix}app/views/jst", "#{prefix}#{@options[:output]}"
         rescue Exception => e
           ::Guard::Notifier.notify(e.to_s, :title => path.sub('app/views/jst/', ''), :image => :failed)
         end