Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with passing variables to and from a sub-workflow #13

Open
sgehrig opened this issue Jan 17, 2018 · 0 comments
Open

Issue with passing variables to and from a sub-workflow #13

sgehrig opened this issue Jan 17, 2018 · 0 comments

Comments

@sgehrig
Copy link

sgehrig commented Jan 17, 2018

Due to some issues within \ezcWorkflowNodeSubWorkflow it is not possible to pass variables from the parent workflow to a sub-workflow and vice versa.

There are three distinct problems:

  1. When a sub-workflow is resumed variables from the parent workflow are not mapped to the variables names in the sub-workflow (based on the variable mapping configuration): zetacomponents/workflow/src/nodes/sub_workflow.php:166
  2. When the waitingFor variables from the sub-workflow are being fed back to the parent workflow the names are again not mapped back to the variables names in the parent workflow (based on the variable mapping configuration): zetacomponents/workflow/src/nodes/sub_workflow.php:191-194
  3. The \ezcWorkflowNodeSubWorkflow::passVariables() method does not check whether a variable exists in the from workflow resulting in an exception if a variable is mapped but not yet set on the from workflow.

I'll provide a pull request to fix these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant