-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for System.Uri #907
Comments
Would you like to make a pull request for that? |
I'll keep it on the back of my mind, but right now I'm swamped with my normal work. |
Hi! I am not a pro in C# but maybe I can help here?
Does that mean that all the parsing should be delegated to |
Yes, that was my proposal. The |
For some reason I can't run tests from master on mac os.
|
This issue has been automatically marked as stale because it has not had activity for 365 days. It will be closed if no further activity occurs within 56 days. Thank you for your contributions. |
Just did some testing with this issue, and the ZeroMQ endpoint |
Environment
Expected behaviour
Calling
Connect
on a NetMQSocket expects a special-formatted string that closely resembles an URI. The API should accept an actual System.Uri where appropriate.Actual behaviour
In my application, I wired up a System.Uri and at the
Connect
call site converted that to a string with.ToString()
. The resulting string resulted in a parsing exception.The string from
Uri.ToString()
contains a trailing slash and this confuses the string-based parsing of the port number. Basing the API off of System.Uri could re-use the existing parsing in .NET and avoid that.Steps to reproduce the behaviour
The text was updated successfully, but these errors were encountered: