Increase code coverage

[moreal]

Now we need to increase the coverage...

Originally posted by @somdoron in #848 (comment)

I agree for it. In my thought, the codecov should be added into required checks (e.g., appveyor build, CodeFactor, ...) to stop the decreasement of the coverage. Please leave your opinions about this .😀

[somdoron]

Sounds good to me

[moreal]

Yeah, I expect it will help stay code stable 😄. Is this needed more discussion? or it's ready to apply?

[somdoron]

Lets leave it open. If you want to change anything at the project level let me know and I would give you a permission

…

On Thu, Feb 6, 2020, 02:58 Lee Dogeon ***@***.***> wrote: It seems already applied. Is it better to close this? Or is it better to leave it open for reminding? Tell me your opinions. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#849?email_source=notifications&email_token=AAUW75R4O4YW3HUZOAWEYSLRBPULVA5CNFSM4KLYWMJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK6ZJZY#issuecomment-582849767>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAUW75VK7OT6CBVNNHNR6G3RBPULVANCNFSM4KLYWMJQ> .

[moreal]

I'm sorry to delete the comment because it was not really applied yet.

Now there are some checks like below.

But I also want to add codecov as checks like below. because if not, it can be merged without check ing code coverage of it.

Further more, I want to suggest to set up an issue management strategy and pre-release. Also I'm sorry but I couldn't understand completely what the permission means there.. Could you let me know more about it please?

Lets leave it open. If you want to change anything at the project level let me know and I would give you a permission
…
On Thu, Feb 6, 2020, 02:58 Lee Dogeon @.***> wrote: It seems already applied. Is it better to close this? Or is it better to leave it open for reminding? Tell me your opinions. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#849?email_source=notifications&email_token=AAUW75R4O4YW3HUZOAWEYSLRBPULVA5CNFSM4KLYWMJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK6ZJZY#issuecomment-582849767>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUW75VK7OT6CBVNNHNR6G3RBPULVANCNFSM4KLYWMJQ .

[moreal]

If there was some parts I didn't understood well, please let me know that. @somdoron

[somdoron]

@moreal I'm not sure what I need to do in order to add the codecov, can you link to a tutorial or something?

[moreal]

There is helpful document provided from codecov, here. I'm not sure but it might require to install codecov github app on this repository! If there was hard to set up and the document is not enough, I'll try to write simple tutorial with gist or screen capture. Or it's just thought, if you can give me a temporary permission, I could try it.

[somdoron]

if you can give me a temporary permission, I could try it.

that is what I suggest earlier.

[somdoron]

you have access.

[moreal]

if you can give me a temporary permission, I could try it.

that is what I suggest earlier.

I have understood.

you have access.

Then that means you gave me access permission already? If not, let's set the date and time you gave access!

[somdoron]

I gave you a permission

…

On Tue, Feb 11, 2020, 02:54 Lee Dogeon ***@***.***> wrote: if you can give me a temporary permission, I could try it. that is what I suggest earlier. I have understood. you have access. Then that means you gave me access permission already? If not, let's set the date and time you gave access! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#849?email_source=notifications&email_token=AAUW75XMH6FRTBC7YUX7LGDRCHZLXA5CNFSM4KLYWMJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELK3OKA#issuecomment-584431400>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAUW75WTVPLQXM7P7V6HXODRCHZLXANCNFSM4KLYWMJQ> .

[moreal]

Ok, I saw and got it. I sent request to install codecov github app, please check email or notification about it. And I couldn't access to Settings -> Branches -> Branch protection rules even I got the permission. It might the permission not enough to access there.

PS. I commented Settings -> Branches -> Branch protection rules because we can set required commit statuses there. I left additional lines because it is important security part

[moreal]

I open pull request to resolve the problem.

[stale]

This issue has been automatically marked as stale because it has not had activity for 365 days. It will be closed if no further activity occurs within 56 days. Thank you for your contributions.

[moreal]

I let this issue stay opened to encourage contributors to increase code coverage with test code when writing pull request. So this issue should not be closed and is not stale.