You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Stack sizes should have defaults that can be set by applications, boards should not set values for these symbols in *_defconfig files, the following is a list of where this is currently done which should be moved to Kconfig.defconfig files:
For the above, if this is something that should be defaulted for all boards based on those SoCs then please move to soc/<soc>/*/Kconfig.default file e.g.
config MAIN_STACK_SIZE
default 2048
config IDLE_STACK_SIZE
default 512 if SOC_SERIES_blah
If it is a board requirements then move to boards/<board>/Kconfig.defconfig file e.g.
config MAIN_STACK_SIZE
default 2048
config IDLE_STACK_SIZE
default 512 if BOARD_blah_cpucluster_blah
Additionally check compliance needs to be updated to specify if disallowed symbols apply to board defconfig files only or also SoC Kconfig.defconfig files too
The text was updated successfully, but these errors were encountered:
Agree with this effort. is this documented somewhere as a guideline? Would be great to have this somewhere.
Would also be nice to start catching this in CI somewhere, so we do not end up with new ones being added.
Some simulators and special variants of those probably need that, but can be done in the SoC as suggested above.
Agree with this effort. is this documented somewhere as a guideline? Would be great to have this somewhere. Would also be nice to start catching this in CI somewhere, so we do not end up with new ones being added.
Some simulators and special variants of those probably need that, but can be done in the SoC as suggested above.
Not documented, once cleaned up will add to the disallowed defconfig compliance check though so will fail CI (like currently with PINCTRL) if present in a PR
Stack sizes should have defaults that can be set by applications, boards should not set values for these symbols in *_defconfig files, the following is a list of where this is currently done which should be moved to Kconfig.defconfig files:
@erwango
@dleach02 @mmahadevan108
@dcpleung
@ifyall
@jhedberg
@nordicjm
For the above, if this is something that should be defaulted for all boards based on those SoCs then please move to
soc/<soc>/*/Kconfig.default
file e.g.If it is a board requirements then move to
boards/<board>/Kconfig.defconfig
file e.g.See https://github.com/zephyrproject-rtos/zephyr/pull/85364/files for an example
The text was updated successfully, but these errors were encountered: