Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

video_flush() called with VIDEO_EP_ALL, unsupported by most drivers #78712

Open
josuah opened this issue Sep 19, 2024 · 0 comments
Open

video_flush() called with VIDEO_EP_ALL, unsupported by most drivers #78712

josuah opened this issue Sep 19, 2024 · 0 comments
Assignees
Labels
area: Drivers area: Video Video subsystem bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@josuah
Copy link
Collaborator

josuah commented Sep 19, 2024

Describe the bug

The video API calls video_flush() from video_stream_stop() with ep=VIDEO_EP_ALL to flush all endpoints before stopping the stream.

Currently, most "data mover" drivers (not the sensors but MIPI/DVP ones) only filter VIDEO_EP_OUT
https://github.com/zephyrproject-rtos/zephyr/blob/main/include/zephyr/drivers/video.h#L456

Expected behavior

Calling video_stream_stop() succeeds on all video drivers supporting it.

Impact

The flush operation would fail upon calling video_stream_stop() for affected drivers.

Environment (please complete the following information):

  • OS: (e.g. Linux, MacOS, Windows)
  • Toolchain (e.g Zephyr SDK, ...)
  • Commit SHA or Version used

Additional context

if (ep != VIDEO_EP_OUT) would need to be converted to if (ep != VIDEO_EP_OUT && ep != VIDEO_EP_ALL).
A PR with macros integrating this will be opened.

@josuah josuah added bug The issue is a bug, or the PR is fixing a bug area: Drivers area: Video Video subsystem labels Sep 19, 2024
@josuah josuah self-assigned this Sep 19, 2024
@dkalowsk dkalowsk added the priority: low Low impact/importance bug label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Drivers area: Video Video subsystem bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

No branches or pull requests

2 participants