-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change formats props make editor disappear #836
Comments
This issue only exist in v2.0.0 and in v1 there is no problem |
I am getting the same when changing the theme prop. Demo: https://codesandbox.io/s/elated-hodgkin-39380o?file=/src/App.js |
* This fixes an issue (zenoamaro#836) where the editor disappears on certain prop changes
PR #838 submitted |
Is it the same as #833 ? |
I think so. My PR should fix both. |
@zenoamaro can we get #833 merged and released please? v2.0.0 doesn't work at all with react 18. |
Same problem here, and successfully fixed with the changes of @duhdugg. Tks man! |
bump on this |
Bumping @zenoamaro |
bumping @zenoamaro |
1 similar comment
bumping @zenoamaro |
Bumping @zenoamaro |
is this library even supported anymore ? this caused critical error on our production!!! how is this not fixed for almost 2 years? |
@ondravondra Are you willing to maintain a fork? I think the project has been abandoned. |
@esetnik I am interested in maintaining a fork. |
@abrarhayat ok great, want to setup a repo and get something published on NPM? |
Here is my fork: https://github.com/abrarhayat/react-quill-abrarhayat And here it is released: https://www.npmjs.com/package/react-quill-abrarhayat This release has the fix from @duhdugg |
This fixes an issue (zenoamaro#836) where the editor disappears on certain prop changes
We can fix this problem by extending the class ReactQuillFixed extends ReactQuill {
destroyEditor(): void {
super.destroyEditor();
delete this.editor;
}
} |
Ticket due diligence
v2.0.0-beta.2
ReactQuill version
FAQ
Is this a bug in Quill or ReactQuill? ReactQuill
When I try to change formats on some events it make editor to disappear
demo: https://codesandbox.io/s/ancient-lake-nss6wi?file=/src/App.js
The text was updated successfully, but these errors were encountered: