Switch to rspec to get CI running

Author: Nathan Sutton

Diff for: .gitignore

@@ -9,3 +9,5 @@ Gemfile.lock
 .zenflow-log
 .ruby-gemset
 .ruby-version
+/.byebug-history
+/.tool-versions

Diff for: .rspec

@@ -0,0 +1 @@
+--require spec_helper

Diff for: Gemfile

@@ -1,18 +1,3 @@
 source 'https://rubygems.org'
 
-gem "multi_json"
-
-group :test do
-  gem "shoulda", "2.11.3"
-  gem "mocha"
-  gem "webmock", "~>1.6.0"
-end
-
-group :development do
-  gem "jruby-openssl", :platforms => :jruby
-  gem "typhoeus",      :platforms => [:mri_18, :mri_19, :mri_20, :mri_21]
-end
-
-group :test, :development do
-  gem "rake"
-end
+gemspec

Diff for: Rakefile

@@ -1,11 +1,8 @@
 require 'rubygems'
-require 'rake'
-require 'rake/testtask'
 
-Rake::TestTask.new(:test) do |test|
-  test.libs << 'lib' << 'test'
-  test.pattern = 'test/**/*_test.rb'
-  test.verbose = true
+begin
+  require 'rspec/core/rake_task'
+  RSpec::Core::RakeTask.new(:spec)
+  task :default => :spec
+rescue LoadError
 end
-
-task :default => :test

Diff for: spec/spec_helper.rb

@@ -0,0 +1,54 @@
+require "rubygems"
+require "bundler"
+Bundler.setup
+Bundler.require(:default, :test, :development)
+require 'test/unit/assertions'
+require 'webmock/rspec'
+
+RSpec.configure do |config|
+  config.include Test::Unit::Assertions
+
+  def assert_same_elements(a1, a2, msg = nil)
+    [:select, :inject, :size].each do |m|
+      [a1, a2].each {|a| assert_respond_to(a, m, "Are you sure that #{a.inspect} is an array?  It doesn't respond to #{m}.") }
+    end
+
+    assert a1h = a1.inject({}) { |h,e| h[e] ||= a1.select { |i| i == e }.size; h }
+    assert a2h = a2.inject({}) { |h,e| h[e] ||= a2.select { |i| i == e }.size; h }
+
+    assert_equal(a1h, a2h, msg)
+  end
+
+  config.after(:example) do
+    ENV["ZENCODER_API_KEY"] = nil
+    Zencoder.api_key = nil
+  end
+
+  config.expect_with :rspec do |expectations|
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  config.mock_with :rspec do |mocks|
+    mocks.verify_partial_doubles = true
+  end
+
+  config.shared_context_metadata_behavior = :apply_to_host_groups
+
+  config.filter_run_when_matching :focus
+
+  # config.example_status_persistence_file_path = "spec/examples.txt"
+
+  config.disable_monkey_patching!
+
+  config.warnings = true
+
+  if config.files_to_run.one?
+    config.default_formatter = "doc"
+  end
+
+  # config.profile_examples = 10
+
+  config.order = :random
+
+  Kernel.srand config.seed
+end

Diff for: spec/zencoder/account_spec.rb

@@ -0,0 +1,53 @@
+require "spec_helper"
+
+RSpec.describe Zencoder::Account do
+  before do
+    @api_key = 'abc123'
+  end
+
+  describe ".create" do
+    before do
+      @url = "#{Zencoder.base_url}/account"
+      @params = {:api_key => @api_key}
+      @params_as_json = Zencoder::Serializer.encode(@params)
+    end
+
+    it "POSTs to the correct url and return a response" do
+      expect(Zencoder::HTTP).to receive(:post).with(@url, @params_as_json, {}).and_return(Zencoder::Response.new)
+      assert_equal Zencoder::Response, Zencoder::Account.create(@params).class
+    end
+  end
+
+  describe ".details" do
+    before do
+      @url = "#{Zencoder.base_url}/account"
+    end
+
+    it "GETs the correct url and return a response" do
+      expect(Zencoder::HTTP).to receive(:get).with(@url, :headers => { "Zencoder-Api-Key" => @api_key }).and_return(Zencoder::Response.new)
+      assert_equal Zencoder::Response, Zencoder::Account.details(:api_key => @api_key).class
+    end
+  end
+
+  describe ".integration" do
+    before do
+      @url = "#{Zencoder.base_url}/account/integration"
+    end
+
+    it "PUTs the correct url and return a response" do
+      expect(Zencoder::HTTP).to receive(:put).with(@url, nil, :headers => { "Zencoder-Api-Key" => @api_key }).and_return(Zencoder::Response.new)
+      assert_equal Zencoder::Response, Zencoder::Account.integration(:api_key => @api_key).class
+    end
+  end
+
+  describe ".live" do
+    before do
+      @url = "#{Zencoder.base_url}/account/live"
+    end
+
+    it "PUTs the correct url and return a response" do
+      expect(Zencoder::HTTP).to receive(:put).with(@url, nil, :headers => { "Zencoder-Api-Key" => @api_key }).and_return(Zencoder::Response.new)
+      assert_equal Zencoder::Response, Zencoder::Account.live(:api_key => @api_key).class
+    end
+  end
+end

Diff for: spec/zencoder/http/net_http_spec.rb

@@ -0,0 +1,121 @@
+require "spec_helper"
+
+RSpec.describe Zencoder::HTTP::NetHTTP do
+
+  describe "call options" do
+    it "requests with timeout" do
+      stub_request(:post, "https://example.com")
+      expect(Timeout).to receive(:timeout).with(0.001)
+      Zencoder::HTTP::NetHTTP.post('https://example.com', :timeout => 1)
+    end
+
+    it "requests without timeout" do
+      stub_request(:post, "https://example.com")
+      allow(Timeout).to receive(:timeout).and_raise(Timeout::Error)
+      assert_nothing_raised do
+        Zencoder::HTTP::NetHTTP.post('https://example.com', :timeout => nil)
+      end
+    end
+
+    it "adds params to the query string if passed" do
+      stub_request(:post, "https://example.com/path?some=param")
+      Zencoder::HTTP::NetHTTP.post('https://example.com/path', {:params => {:some => 'param'}})
+    end
+
+    it "adds params to the existing query string if passed" do
+      stub_request(:post,'https://example.com/path?original=param&some=param')
+      Zencoder::HTTP::NetHTTP.post('https://example.com/path?original=param', {:params => {:some => 'param'}})
+    end
+
+    it "adds headers" do
+      stub_request(:post,'https://example.com/path').with(:headers => {'some' => 'header'})
+      Zencoder::HTTP::NetHTTP.post('https://example.com/path', {:headers => {:some => 'header'}})
+    end
+
+    it "adds the body to the request" do
+      stub_request(:post, 'https://example.com/path').with(:body => '{"some": "body"}')
+      Zencoder::HTTP::NetHTTP.post('https://example.com/path', {:body => '{"some": "body"}'})
+    end
+  end
+
+  describe "SSL verification" do
+    before do
+      @cert_store = double(:add_file => true, :add_path => true, :flags= => true, :set_default_paths => true).as_null_object
+      @http_stub = double(:use_ssl= => true, :request => true, :verify_mode= => true, :cert_store= => true, :cert_store => @cert_store).as_null_object
+      expect(::Net::HTTP).to receive(:new).and_return(@http_stub)
+    end
+
+    describe "when set to skip ssl verification" do
+      it "nots verify" do
+        expect(@http_stub).to receive(:verify_mode=).with(OpenSSL::SSL::VERIFY_NONE)
+        Zencoder::HTTP::NetHTTP.post('https://example.com/path', :skip_ssl_verify => true)
+      end
+
+      it "nots setup a custom cert store" do
+        expect(@http_stub).to_not receive(:cert_store=)
+        Zencoder::HTTP::NetHTTP.post('https://example.com/path', :skip_ssl_verify => true)
+      end
+    end
+
+    describe "when set to do ssl verification" do
+      it "setups a custom cert store" do
+        expect(@http_stub).to receive(:cert_store=)
+        Zencoder::HTTP::NetHTTP.post('https://example.com/path')
+      end
+
+      it "sets the default paths on the custom cert store" do
+        expect(@cert_store).to receive(:set_default_paths)
+        Zencoder::HTTP::NetHTTP.post('https://example.com/path')
+      end
+
+      it "sets the ca_file when it is passed in" do
+        expect(@cert_store).to receive(:add_file).with("/foo/bar/baz.crt")
+        Zencoder::HTTP::NetHTTP.post('https://example.com/path', :ca_file => "/foo/bar/baz.crt")
+      end
+
+      it "sets the ca_path when it is passed in" do
+        expect(@cert_store).to receive(:add_path).with("/foo/bar/")
+        Zencoder::HTTP::NetHTTP.post('https://example.com/path', :ca_path => "/foo/bar/")
+      end
+    end
+
+  end
+
+  describe ".post" do
+    it "POSTs to specified body to the specified path" do
+      stub_request(:post, 'https://example.com').with(:body => '{}')
+      Zencoder::HTTP::NetHTTP.post('https://example.com', :body => '{}')
+    end
+
+    it "POSTs with an empty body if none is provided" do
+      stub_request(:post, 'https://example.com').with(:body => '')
+      Zencoder::HTTP::NetHTTP.post('https://example.com')
+    end
+  end
+
+  describe ".put" do
+    it "PUTs to specified body to the specified path" do
+      stub_request(:put, 'https://example.com').with(:body => '{}')
+      Zencoder::HTTP::NetHTTP.put('https://example.com', :body => '{}')
+    end
+
+    it "PUTs with an empty body if none is provided" do
+      stub_request(:put, 'https://example.com').with(:body => '')
+      Zencoder::HTTP::NetHTTP.put('https://example.com')
+    end
+  end
+
+  describe ".get" do
+    it "GETs to specified body to the specified path" do
+      stub_request(:get, 'https://example.com')
+      Zencoder::HTTP::NetHTTP.get('https://example.com')
+    end
+  end
+
+  describe ".delete" do
+    it "DELETEs to specified body to the specified path" do
+      stub_request(:delete, 'https://example.com')
+      Zencoder::HTTP::NetHTTP.delete('https://example.com')
+    end
+  end
+end

Diff for: spec/zencoder/http/typhoeus_spec.rb

@@ -0,0 +1,55 @@
+require "spec_helper"
+
+# Most useless tests ever, but who knows, right?
+
+if !defined?(Typhoeus)
+  module ::Typhoeus
+    module Request
+    end
+  end
+end
+
+RSpec.describe Zencoder::HTTP::Typhoeus do
+  describe ".post" do
+    it "POSTs using Typhoeus" do
+      expect(Typhoeus::Request).to receive(:post).with('https://example.com', {:some => 'options'})
+      Zencoder::HTTP::Typhoeus.post('https://example.com', {:some => 'options'})
+    end
+  end
+
+  describe ".put" do
+    it "PUTs using Typhoeus" do
+      expect(Typhoeus::Request).to receive(:put).with('https://example.com', {:some => 'options'})
+      Zencoder::HTTP::Typhoeus.put('https://example.com', {:some => 'options'})
+    end
+  end
+
+  describe ".get" do
+    it "GETs using Typhoeus" do
+      expect(Typhoeus::Request).to receive(:get).with('https://example.com', {:some => 'options'})
+      Zencoder::HTTP::Typhoeus.get('https://example.com', {:some => 'options'})
+    end
+  end
+
+  describe ".delete" do
+    it "DELETEs using Typhoeus" do
+      expect(Typhoeus::Request).to receive(:delete).with('https://example.com', {:some => 'options'})
+      Zencoder::HTTP::Typhoeus.delete('https://example.com', {:some => 'options'})
+    end
+  end
+
+  it "skips ssl verification" do
+    expect(Typhoeus::Request).to receive(:get).with('https://example.com', {:disable_ssl_peer_verification => true})
+    Zencoder::HTTP::Typhoeus.get('https://example.com', {:skip_ssl_verify => true})
+  end
+
+  it "uses the path to the cert file" do
+    expect(Typhoeus::Request).to receive(:get).with('https://example.com', {:disable_ssl_peer_verification => true, :sslcert => "/foo/bar/baz.crt"})
+    Zencoder::HTTP::Typhoeus.get('https://example.com', {:skip_ssl_verify => true, :ca_file => "/foo/bar/baz.crt"})
+  end
+
+  it "uses the path to the certs directory" do
+    expect(Typhoeus::Request).to receive(:get).with('https://example.com', {:disable_ssl_peer_verification => true, :capath => "/foo/bar/baz.crt"})
+    Zencoder::HTTP::Typhoeus.get('https://example.com', {:skip_ssl_verify => true, :ca_path => "/foo/bar/baz.crt"})
+  end
+end