Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot run #3

Open
saikek opened this issue Jun 28, 2021 · 5 comments
Open

Cannot run #3

saikek opened this issue Jun 28, 2021 · 5 comments
Assignees
Labels
invalid This doesn't seem right

Comments

@saikek
Copy link

saikek commented Jun 28, 2021

(node:1523) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'number' of undefined
    at run (/home/runner/work/_actions/zattoo/output/v1/dist/index.js:7383:53)
    at Object.676 (/home/runner/work/_actions/zattoo/output/v1/dist/index.js:7445:1)
    at __webpack_require__ (/home/runner/work/_actions/zattoo/output/v1/dist/index.js:24:31)
    at startup (/home/runner/work/_actions/zattoo/output/v1/dist/index.js:43:19)
    at /home/runner/work/_actions/zattoo/output/v1/dist/index.js:47:18
    at Object.<anonymous> (/home/runner/work/_actions/zattoo/output/v1/dist/index.js:50:10)
    at Module._compile (internal/modules/cjs/loader.js:959:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:995:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Function.Module._load (internal/modules/cjs/loader.js:727:14)
(node:1523) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:1523) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
name: Do things
on: push
jobs:
  job1:
    runs-on: ubuntu-latest
    outputs:
      url: ${{ steps.step1.outputs.url }} # map step output to job output
    steps:
      - name: Checkout
        uses: actions/checkout@v2 
      - uses: zattoo/output@v1
        with:
          token: ${{github.token}}
          sources: 'test/HELLO_WORLD.md'
@dobladov
Copy link
Contributor

The action only works in pull requests, if is triggered on: push there is no PR comment to modify.

on:
  pull_request:
    types: [
        opened,
        ready_for_review,
        reopened,
        synchronize,
    ]
    branches:
      - hotfix
      - master

@dobladov dobladov added the invalid This doesn't seem right label Jun 28, 2021
@dobladov dobladov self-assigned this Jun 28, 2021
@saikek
Copy link
Author

saikek commented Jun 29, 2021

Ok, is there something else that i've missed ?

Run zattoo/output@v1
  with:
    token: ***
    sources: file.md
Doing nothing, comment does not need new output or clean up

That's under pull request:

shafr/test#1

There seems to be no output.

@dobladov
Copy link
Contributor

The sources input is pointing to file.md, you need to match the exact file you want to output, or use a glob pattern

         sources: 'dimi/HELLO_WORLD.md'

There seems to be no output.

This is becuase the file was never found.

@saikek
Copy link
Author

saikek commented Jun 29, 2021

Ok, maybe it's messing up data between steps & my echo does not work properly from previous step:

      - name: Echo file
        run: echo "test 1234567890" >> file.md        
      - uses: zattoo/output@v1
        with:
          token:  ${{github.token}}
          sources: 'file.md'

Anyway, even if i'm referencing path dimi/HELLO_WORLD.md there's no data.

@TYoungSL
Copy link

@saikek create a secret ACTIONS_STEP_DEBUG on the repo and set it to true.

The logs will then include debugging output. (Reference documentation.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants