Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Text display orientation and rendering fixes #235

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

Phoenix616
Copy link

@Phoenix616 Phoenix616 commented Nov 27, 2024

This adds more features of text displays and fixes some issues with the current implementation

  • Adds support for fixed text displays
  • Adds support for rotation and transformation
  • Fixes background color issues (they are encoded in 2s complements, not direct integers)
  • Fixes size of text and alignment

Copy link

codesandbox bot commented Nov 27, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

- Adds support for fixed text displays
- Adds support for rotation and transformation
- Fixes background color issues
- Fixes size of text and alignment
@Phoenix616 Phoenix616 force-pushed the pr/text-display-orientations branch from e108288 to f2d4564 Compare November 27, 2024 16:41
@zardoy zardoy changed the title Feat: Text display orientation and rendering fixes feat: Text display orientation and rendering fixes Nov 27, 2024
@zardoy
Copy link
Owner

zardoy commented Nov 27, 2024

Great but does fixed text render fine when it's behind transparent object like stained glass?

@zardoy zardoy merged commit dd20994 into zardoy:next Nov 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants