Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: zapier build follows invalid symlinks when copying #706

Closed
cscorley opened this issue Sep 24, 2023 · 3 comments · Fixed by #737
Closed

[Bug]: zapier build follows invalid symlinks when copying #706

cscorley opened this issue Sep 24, 2023 · 3 comments · Fixed by #737
Labels
bug Something isn't working

Comments

@cscorley
Copy link

Bug Description

Hi team,

I'm running into an issue with my local development environment when running zapier build, it will fail on the first step:

✖ Copying project to temp directory
 ›   Error: ENOENT: no such file or directory, stat
 ›   'hi'

FWIW, this file is in my .gitingore. It would be great if the filter for this step excluded those .gitignore files as well. I see it does this on zipping. Seems like this should occur much sooner.

To be honest, I am not sure why it needs to copy into a separate directory in the first place.

Thanks!

Reproduction Steps

  1. Create a symlink to a file that does not exist: ln -s bye hi
  2. Run zapier build

Zapier Platform version

15.3.0

Node.js version

v18.17.1

Your Operating System

macOS 13.5.2 (22G91)

npm/yarn version

No response

App ID

No response

More Details

No response

@cscorley cscorley added the bug Something isn't working label Sep 24, 2023
@cscorley cscorley changed the title [Bug]: zapier build does not follow symlinks when copying [Bug]: zapier build follows invalid symlinks when copying Sep 24, 2023
@rnegron
Copy link
Member

rnegron commented Jan 29, 2024

Thanks for reporting this bug! I've gone ahead and created a ticket in our internal issue tracker: PDE-4679.

@rnegron
Copy link
Member

rnegron commented Feb 2, 2024

Fixed by #737. We now display a warning message when detecting an invalid symlink and don't crash the build process. Thanks for reporting the issue!

@rnegron rnegron closed this as completed Feb 2, 2024
@cscorley
Copy link
Author

cscorley commented Feb 3, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants