-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZapierPromise does not use scoped prototype functionality #481
Comments
@codebycaleb do you have a screenshot of how dire the error messages look? Trying to gauge severity here. And does this only affect CLI apps which separately use bluebird promises? If so, seems fairly narrow. We were just talking about pulling the bluebird stuff out, but it's esoteric and working just fine, so we're hesitant to touch it if we can avoid it. |
ok, cool! Good to know. Yeah, it's the first I've heard of it too. We'll keep this open in case other people have the same issue, but it doesn't strike me as a priority. |
Just noting I have very similar symptoms but I am not using bluebird in my app directly, it's just imported as a dependency of zapier-platform-core
When I try to test my Zap I get about 20% of the time the error: |
Bug Description
ZapierPromise does not adhere to bluebird's scoped prototypes recommendations regarding
require
ing bluebird.Reproduction Steps
Errors will be logged that cite bluebird's documentation about not invoking the Promise constructor directly.
The code should work without errors.
Version Info
The text was updated successfully, but these errors were encountered: