You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Lua has this notion of "dumping" (serialising to a binary string) functions when they are GCd. Later they can be "undumped" back into Protos. A Proto is where we store our yk locations array.
@Pavel-Durov knew about this is the "old" branch, and attempted a fix: #32
When we upgraded the Lua version, that change wasn't carried over.
Since we don't dump/undump the yk locations, I'd expect uninitialised memory accesses. but @Pavel-Durov was saying that it fixes a use after free. I'm not sure why that would be.
If/when we want to revisit this, we should review the old branch change, because it looks to me like it creates new yk locations upon undump, leaving the old ones to leak(?).
The text was updated successfully, but these errors were encountered:
Lua has this notion of "dumping" (serialising to a binary string) functions when they are GCd. Later they can be "undumped" back into
Proto
s. AProto
is where we store our yk locations array.@Pavel-Durov knew about this is the "old" branch, and attempted a fix:
#32
When we upgraded the Lua version, that change wasn't carried over.
Since we don't dump/undump the yk locations, I'd expect uninitialised memory accesses. but @Pavel-Durov was saying that it fixes a use after free. I'm not sure why that would be.
If/when we want to revisit this, we should review the old branch change, because it looks to me like it creates new yk locations upon undump, leaving the old ones to leak(?).
The text was updated successfully, but these errors were encountered: