Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StreamTransport does not verify SSL certificates #222

Open
cebe opened this issue Nov 8, 2022 · 3 comments
Open

StreamTransport does not verify SSL certificates #222

cebe opened this issue Nov 8, 2022 · 3 comments

Comments

@cebe
Copy link
Member

cebe commented Nov 8, 2022

What steps will reproduce the problem?

'ssl' => [
'verify_peer' => false,
],

What's expected?

This value should be configurable via a property and the default should be true instead of false.

Additional info

Q A
Yii version not relevant
Yii HTTP Client version all
PHP version not relevant
Operating system all
@cebe cebe added status:ready for adoption Feel free to implement this issue. good first issue Simple enough issue to start with. severity:important severity:security Affects security labels Nov 8, 2022
@schmunk42
Copy link

Do you mean a standalone property? Because isn't it configurable via options, see here?

I agree about the security implications, but it also might break several exisiting apps.

@cebe
Copy link
Member Author

cebe commented Nov 9, 2022

Because isn't it configurable via options, see here?

good point, did not notice it was configurable like that.

It is "only" a bad default then.

@cebe cebe added status:under discussion and removed status:ready for adoption Feel free to implement this issue. good first issue Simple enough issue to start with. labels Nov 9, 2022
@samdark
Copy link
Member

samdark commented Nov 13, 2022

Yes, default should be adjusted. No need to add a dedicated property though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants