Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do GET_SDK_VERSION before operator_full_registration #1778

Merged
merged 2 commits into from
Feb 7, 2025
Merged

fix: do GET_SDK_VERSION before operator_full_registration #1778

merged 2 commits into from
Feb 7, 2025

Conversation

uri-99
Copy link
Contributor

@uri-99 uri-99 commented Jan 27, 2025

GET_SDK_VERSION before operator_full_registration

Description

the appropriate SDK version is required during registration, this is why GET_SDK_VERSION should be done before make operator_full_registration, and not directly in make operator_start.

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@uri-99 uri-99 linked an issue Jan 27, 2025 that may be closed by this pull request
fix: do GET_SDK_VERSION before operator_full_registration #1777
Open
@uri-99 uri-99 changed the base branch from testnet to staging January 28, 2025 14:07
@JuArce JuArce added this pull request to the merge queue Feb 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025
@MauroToscano MauroToscano added this pull request to the merge queue Feb 7, 2025
Merged via the queue into staging with commit afd03c7 Feb 7, 2025
1 check passed
@MauroToscano MauroToscano deleted the 1777-fix-do-get_sdk_version-before-operator_full_registration branch February 7, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MauroToscano MauroToscano MauroToscano approved these changes

@JuArce JuArce JuArce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: do GET_SDK_VERSION before operator_full_registration
3 participants
@uri-99 @MauroToscano @JuArce