Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Outlook Extension (React JS) JavaScript Sample (Again) #813

Open
RA-Davies opened this issue Jul 10, 2024 · 1 comment
Open

Broken Outlook Extension (React JS) JavaScript Sample (Again) #813

RA-Davies opened this issue Jul 10, 2024 · 1 comment

Comments

@RA-Davies
Copy link

RA-Davies commented Jul 10, 2024

Once again we appear to have a non-working (quite broken) yo generator for React JS Outlook add-in.

Previously, if you recall we had an invalid self-closed <Host xsi:type="MailHost"/> which - after quite some sleuthing I was able to resolve and build an add-in without issue. It looks like you've now solved, this but much worse things appear to happen using yo office when creating a React JS Outlook add-in (JavaScript) version... the package.json generated starts with:

0.2",
"eslint-plugin-react": "^7.28.0",
"file-loader": "^6.2.0",
"find-process": "^1.4.4",
"html-loader": "^5.0.0",
"html-webpack-plugin": "^5.6.0",

...
..

Which of course is wrong and will lead to broken JSON that doesn't parse, leading to a project that won't build

Can I politely suggest you test these things before pushing them out?

In the meantime, does anyone have a valid (current) packages.json sample for this type of project (as I can see both this and the manifest.xml has changed a lot since I last used it)

@RA-Davies
Copy link
Author

RA-Davies commented Jul 10, 2024

If it helps, the complete log after running yo office is:

I'm all done. Running npm install for you to install the required dependencies. If this fails, try running the command yourself.

npm WARN config cache-min This option has been deprecated in favor of --prefer-offline.
npm ERR! code EJSONPARSE
npm ERR! path C:...blahblah.../projectname/package.json
npm ERR! JSON.parse Unexpected non-whitespace character after JSON at position 3 while parsing '0.2",
npm ERR! JSON.parse "eslint-plugin-react": "^7.28.'
npm ERR! JSON.parse Failed to parse JSON data.
npm ERR! JSON.parse Note: package.json must be actual JSON, not just JavaScript.

npm ERR! A complete log of this run can be found in:.... .debug.log

No change to package.json was detected. No package manager install will be executed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant