chore: compute Node.js build target from engines.node (#5554)

**What's the problem this PR addresses?**

Whenever we change the supported Node.js version we have to manually
update the build target in multiple files.

Ref
yarnpkg/berry#5445 (review)

**How did you fix it?**

Automate it by computing the Node.js version to target for the builds
with `semver.minVersion` and `engines.node`.

**Checklist**
- [x] I have read the [Contributing
Guide](https://yarnpkg.com/advanced/contributing).
- [x] I have set the packages that need to be released for my changes to
be effective.
- [x] I will check that all automated PR checks pass before the PR gets
reviewed.

Author: merceyz

.pnp.cjs

@@ -0,0 +1,5 @@
+declined:
+  - vscode-zipfs
+  - "@yarnpkg/builder"
+  - "@yarnpkg/core"
+  - "@yarnpkg/pnp"

.yarn/versions/8a86268c.yml

@@ -1,14 +1,10 @@
 module.exports = {
   targets: {
-    node: `18.12.0`,
+    node: `current`,
   },
   presets: [
     [`@babel/preset-env`, {modules: `commonjs`}],
     `@babel/preset-typescript`,
     `@babel/preset-react`,
   ],
-  ignore: [
-    `**/*.d.ts`,
-    `packages/yarnpkg-libzip/sources/libzip.js`,
-  ],
 };

babel.config.js

@@ -91,13 +91,15 @@
   "devDependencies": {
     "@rollup/plugin-commonjs": "^21.0.1",
     "@rollup/plugin-node-resolve": "^11.0.1",
+    "@types/semver": "^7.1.0",
     "@types/vscode": "^1.54.0",
     "@yarnpkg/fslib": "workspace:^",
     "@yarnpkg/libzip": "workspace:^",
     "esbuild": "npm:esbuild-wasm@^0.15.15",
     "rollup": "^2.59.0",
     "rollup-plugin-esbuild": "^3.0.2",
     "rollup-plugin-terser": "^7.0.2",
+    "semver": "^7.1.2",
     "vsce": "^2.9.2"
   },
   "scripts": {

packages/vscode-zipfs/package.json

@@ -3,6 +3,9 @@ import resolve        from '@rollup/plugin-node-resolve';
 import path           from 'path';
 import esbuild        from 'rollup-plugin-esbuild';
 import {defineConfig} from 'rollup';
+import semver         from 'semver';
+
+import pkg            from './package.json';
 
 const mode = process.env.NODE_ENV || `production`;
 
@@ -24,7 +27,7 @@ export default async () =>
       }),
       esbuild({
         tsconfig: false,
-        target: `node18`,
+        target: `node${semver.minVersion(pkg.engines.node).version}`,
         define: {
           document: `undefined`,
           XMLHttpRequest: `undefined`,

packages/vscode-zipfs/rollup.config.js

@@ -11,6 +11,7 @@ import path                                                                 from
 import semver                                                               from 'semver';
 import {promisify}                                                          from 'util';
 
+import pkg                                                                  from '../../../package.json';
 import {findPlugins}                                                        from '../../tools/findPlugins';
 
 const execFile = promisify(cp.execFile);
@@ -140,7 +141,7 @@ export default class BuildBundleCommand extends Command {
           plugins: [valLoader],
           minify: !this.noMinify,
           sourcemap: this.sourceMap ? `inline` : false,
-          target: `node18`,
+          target: `node${semver.minVersion(pkg.engines.node)!.version}`,
         });
 
         for (const warning of res.warnings) {

packages/yarnpkg-builder/sources/commands/build/bundle.ts

@@ -4,7 +4,9 @@ import {Command, Option, Usage, UsageError}                                 from
 import {build, Plugin}                                                      from 'esbuild';
 import fs                                                                   from 'fs';
 import path                                                                 from 'path';
+import semver                                                               from 'semver';
 
+import pkg                                                                  from '../../../package.json';
 import {isDynamicLib}                                                       from '../../tools/isDynamicLib';
 
 const matchAll = /()/;
@@ -120,7 +122,7 @@ export default class BuildPluginCommand extends Command {
           plugins: [dynamicLibResolver],
           minify: !this.noMinify,
           sourcemap: this.sourceMap ? `inline` : false,
-          target: `node18`,
+          target: `node${semver.minVersion(pkg.engines.node)!.version}`,
         });
 
         for (const warning of res.warnings) {

packages/yarnpkg-builder/sources/commands/build/plugin.ts

@@ -5,8 +5,11 @@ import path                 from 'path';
 import esbuild              from 'rollup-plugin-esbuild';
 import {terser}             from 'rollup-plugin-terser';
 import {defineConfig}       from 'rollup';
+import semver               from 'semver';
 import {brotliCompressSync} from 'zlib';
 
+import pkg                  from './package.json';
+
 function wrapOutput() {
   return {
     name: `wrap-output`,
@@ -43,7 +46,7 @@ export default defineConfig({
     }),
     esbuild({
       tsconfig: false,
-      target: `node18`,
+      target: `node${semver.minVersion(pkg.engines.node).version}`,
       define: {
         document: `undefined`,
         XMLHttpRequest: `undefined`,

packages/yarnpkg-core/rollup.config.js

@@ -16,11 +16,13 @@
   "devDependencies": {
     "@rollup/plugin-commonjs": "^21.0.1",
     "@rollup/plugin-node-resolve": "^11.0.1",
+    "@types/semver": "^7.1.0",
     "@yarnpkg/libzip": "workspace:^",
     "arg": "^5.0.2",
     "esbuild": "npm:esbuild-wasm@^0.15.15",
     "rollup": "^2.59.0",
     "rollup-plugin-esbuild": "^3.0.2",
+    "semver": "^7.1.2",
     "tslib": "^2.4.0"
   },
   "scripts": {

packages/yarnpkg-core/sources/worker-zip/index.js

@@ -3,8 +3,11 @@ import resolve              from '@rollup/plugin-node-resolve';
 import path                 from 'path';
 import esbuild              from 'rollup-plugin-esbuild';
 import {defineConfig}       from 'rollup';
+import semver               from 'semver';
 import {brotliCompressSync} from 'zlib';
 
+import pkg                  from './package.json';
+
 function wrapOutput() {
   return {
     name: `wrap-output`,
@@ -42,7 +45,7 @@ export default defineConfig([
       }),
       esbuild({
         tsconfig: false,
-        target: `node18`,
+        target: `node${semver.minVersion(pkg.engines.node).version}`,
         define: {
           document: `undefined`,
           XMLHttpRequest: `undefined`,
@@ -69,7 +72,7 @@ export default defineConfig([
       }),
       esbuild({
         tsconfig: false,
-        target: `node18`,
+        target: `node${semver.minVersion(pkg.engines.node).version}`,
         define: {
           document: `undefined`,
           XMLHttpRequest: `undefined`,
@@ -97,7 +100,7 @@ export default defineConfig([
         }),
         esbuild({
           tsconfig: false,
-          target: `node18`,
+          target: `node${semver.minVersion(pkg.engines.node).version}`,
           define: {
             document: `undefined`,
             XMLHttpRequest: `undefined`,

packages/yarnpkg-pnp/package.json

@@ -7848,12 +7848,14 @@ __metadata:
     "@rollup/plugin-commonjs": "npm:^21.0.1"
     "@rollup/plugin-node-resolve": "npm:^11.0.1"
     "@types/node": "npm:^18.15.11"
+    "@types/semver": "npm:^7.1.0"
     "@yarnpkg/fslib": "workspace:^"
     "@yarnpkg/libzip": "workspace:^"
     arg: "npm:^5.0.2"
     esbuild: "npm:esbuild-wasm@^0.15.15"
     rollup: "npm:^2.59.0"
     rollup-plugin-esbuild: "npm:^3.0.2"
+    semver: "npm:^7.1.2"
     tslib: "npm:^2.4.0"
   languageName: unknown
   linkType: soft
@@ -30250,13 +30252,15 @@ pem@dexus/pem:
   dependencies:
     "@rollup/plugin-commonjs": "npm:^21.0.1"
     "@rollup/plugin-node-resolve": "npm:^11.0.1"
+    "@types/semver": "npm:^7.1.0"
     "@types/vscode": "npm:^1.54.0"
     "@yarnpkg/fslib": "workspace:^"
     "@yarnpkg/libzip": "workspace:^"
     esbuild: "npm:esbuild-wasm@^0.15.15"
     rollup: "npm:^2.59.0"
     rollup-plugin-esbuild: "npm:^3.0.2"
     rollup-plugin-terser: "npm:^7.0.2"
+    semver: "npm:^7.1.2"
     tslib: "npm:^2.4.0"
     vsce: "npm:^2.9.2"
   languageName: unknown