Skip to content

Commit 29e3f12

Browse files
kanglanttensorflower-gardener
authored andcommitted
Add -oss_excluded to TF build/test tag filters
Currently, `no_oss` is used to exclude a test from running in the official TF OSS test infrastructure. However, it is difficult to distinguish between temporary and permanent exclusions. For example, a test may be disabled temporarily if it is broken, or it may be designed to not run on OSS permanently. To address this issue, we introduce a new tag `oss_excluded` for platform exclusion design. `no_oss` will now be considered to disable broken tests, while `oss_excluded` will be used to permanently exclude a test from running on OSS. PiperOrigin-RevId: 516372702
1 parent e7a2034 commit 29e3f12

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

CONTRIBUTING.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ You can run all the tests locally by running the following command in the repo
248248
root directory.
249249

250250
```
251-
bazel test --test_timeout 300,450,1200,3600 --test_output=errors --keep_going --define=use_fast_cpp_protos=false --build_tests_only --build_tag_filters=-no_oss --test_tag_filters=-no_oss keras/...
251+
bazel test --test_timeout 300,450,1200,3600 --test_output=errors --keep_going --define=use_fast_cpp_protos=false --build_tests_only --build_tag_filters=-no_oss,-oss_excluded --test_tag_filters=-no_oss,-oss_excluded keras/...
252252
```
253253

254254
### Useful configs

keras/kokoro/github/ubuntu/cpu/build.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,6 @@ pip uninstall -y keras-nightly
4343
bazel test --test_timeout 300,450,1200,3600 --test_output=errors --keep_going \
4444
--define=use_fast_cpp_protos=false \
4545
--build_tests_only \
46-
--build_tag_filters="-no_oss" \
47-
--test_tag_filters="-no_oss" \
46+
--build_tag_filters="-no_oss,-oss_excluded" \
47+
--test_tag_filters="-no_oss,-oss_excluded" \
4848
-- //keras/...

keras/kokoro/github/ubuntu/gpu/build.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ export LD_LIBRARY_PATH="/usr/local/cuda/lib64:/usr/local/cuda/extras/CUPTI/lib64
4444
export TF_CUDA_COMPUTE_CAPABILITIES=6.0
4545
TF_CUDA_CONFIG_REPO="@ubuntu16.04-py3-gcc7_manylinux2010-cuda10.1-cudnn7-tensorrt6.0_config_cuda"
4646

47-
tag_filters="gpu,-no_gpu,-nogpu,-benchmark-test,-no_oss,-oss_serial,-no_gpu_presubmit"
47+
tag_filters="gpu,-no_gpu,-nogpu,-benchmark-test,-no_oss,-oss_excluded,-oss_serial,-no_gpu_presubmit"
4848
# There are only 4 GPU available on the local test machine.
4949
TF_GPU_COUNT=4
5050
TF_TESTS_PER_GPU=8

keras/tools/bazel_build.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ PATH="/home/kbuilder/bin:$PATH"
1414
which bazel
1515
bazel version
1616

17-
TAG_FILTERS="-no_oss,-oss_serial,-gpu,-benchmark-test,-no_oss_py3,-no_pip,-nopip"
17+
TAG_FILTERS="-no_oss,-oss_excluded,-oss_serial,-gpu,-benchmark-test,-no_oss_py3,-no_pip,-nopip"
1818
bazel build \
1919
--define=use_fast_cpp_protos=false \
2020
--build_tag_filters="${TAG_FILTERS}" \

0 commit comments

Comments
 (0)