From 1217bb0d16bb76408ac86a6a40998ad51f99aeea Mon Sep 17 00:00:00 2001 From: Ry Racherbaumer Date: Tue, 11 Mar 2025 13:35:21 -0500 Subject: [PATCH 1/2] Rename member mgmt functions --- sdks/node-sdk/src/Group.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sdks/node-sdk/src/Group.ts b/sdks/node-sdk/src/Group.ts index 30f02b41..4ba5721a 100644 --- a/sdks/node-sdk/src/Group.ts +++ b/sdks/node-sdk/src/Group.ts @@ -81,19 +81,19 @@ export class Group extends Conversation { return this.#conversation.isSuperAdmin(inboxId); } - async addMembers(identifiers: Identifier[]) { + async addMembersByIdentifiers(identifiers: Identifier[]) { return this.#conversation.addMembers(identifiers); } - async addMembersByInboxId(inboxIds: string[]) { + async addMembers(inboxIds: string[]) { return this.#conversation.addMembersByInboxId(inboxIds); } - async removeMembers(identifiers: Identifier[]) { + async removeMembersByIdentifiers(identifiers: Identifier[]) { return this.#conversation.removeMembers(identifiers); } - async removeMembersByInboxId(inboxIds: string[]) { + async removeMembers(inboxIds: string[]) { return this.#conversation.removeMembersByInboxId(inboxIds); } From 82c8c1938a3c0b67d812a4fc6f6efbd188344000 Mon Sep 17 00:00:00 2001 From: Ry Racherbaumer Date: Tue, 11 Mar 2025 13:41:26 -0500 Subject: [PATCH 2/2] Update tests --- sdks/node-sdk/test/Conversation.test.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sdks/node-sdk/test/Conversation.test.ts b/sdks/node-sdk/test/Conversation.test.ts index 4fd78b02..00d8244d 100644 --- a/sdks/node-sdk/test/Conversation.test.ts +++ b/sdks/node-sdk/test/Conversation.test.ts @@ -124,7 +124,7 @@ describe.concurrent("Conversation", () => { expect(memberInboxIds).toContain(client2.inboxId); expect(memberInboxIds).not.toContain(client3.inboxId); - await conversation.addMembers([await signer3.getIdentifier()]); + await conversation.addMembers([client3.inboxId]); const members2 = await conversation.members(); expect(members2.length).toBe(3); @@ -134,7 +134,7 @@ describe.concurrent("Conversation", () => { expect(memberInboxIds2).toContain(client2.inboxId); expect(memberInboxIds2).toContain(client3.inboxId); - await conversation.removeMembers([await signer2.getIdentifier()]); + await conversation.removeMembers([client2.inboxId]); const members3 = await conversation.members(); expect(members3.length).toBe(2); @@ -165,7 +165,7 @@ describe.concurrent("Conversation", () => { expect(memberInboxIds).toContain(client2.inboxId); expect(memberInboxIds).not.toContain(client3.inboxId); - await conversation.addMembersByInboxId([client3.inboxId]); + await conversation.addMembers([client3.inboxId]); const members2 = await conversation.members(); expect(members2.length).toBe(3); @@ -175,7 +175,7 @@ describe.concurrent("Conversation", () => { expect(memberInboxIds2).toContain(client2.inboxId); expect(memberInboxIds2).toContain(client3.inboxId); - await conversation.removeMembersByInboxId([client2.inboxId]); + await conversation.removeMembers([client2.inboxId]); const members3 = await conversation.members(); expect(members3.length).toBe(2);