Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to skip processing vorbis comments #112

Open
bahusoid opened this issue Nov 12, 2024 · 0 comments
Open

Add ability to skip processing vorbis comments #112

bahusoid opened this issue Nov 12, 2024 · 0 comments

Comments

@bahusoid
Copy link

bahusoid commented Nov 12, 2024

I'm trying to play Vorbis files on an MP3 player with only 1 MB of memory available for decoding. Most files play fine, except those with large comments section (files with embedded album art). It fails right on attempt to open stream with ov_open_callbacks.

At this stage, all required metadata is already obtained, so ideally, I'd like to skip processing the comments section completely and load only the audio packets. Is there an easy way to achieve this?

From what I can see, the _fetch_headers function needs to be modified to support this feature. However, it's quite complex for me to understand. It's not as simple as dropping _vorbis_unpack_comment, as I encountered an Out of Memory exception before it's called inside:

ogg_stream_pagein(&vf->os,og_ptr);

Stacktrace:
image

Any help would be really appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant