Allow tag-dir to be inside source-directory

Author: Lars Solberg

HISTORY.rst

@@ -2,6 +2,11 @@
 History
 =======
 
+0.18.0 (2019-12-07)
+-------------------
+
+* Don't create symlinks if it's destination is in the symlink directory. This makes it possible to have the tag-directory inside the source-directory.
+
 0.17.1 (2019-12-06)
 -------------------
 

taggo/__init__.py

@@ -461,6 +461,10 @@ def make_symlink(symlink_basepath, sourcepath, *, nametemplate=None, metadata_st
 
     metadata_store = metadata_store or Metadata()
 
+    if sourcepath.startswith(symlink_basepath):
+        log(f'  * skipping, symlink is already in the destination directory', loglevel='debug')
+        return
+
     is_file = os.path.isfile(sourcepath)
 
     metadata_store.add_multiple('path', _path_variants(os.path.dirname(sourcepath)))

tests/test_cli.py

@@ -3,6 +3,7 @@
 
 import os
 import re
+import glob
 import json
 import shutil
 import textwrap
@@ -91,6 +92,18 @@ def test_frontmatter(tmpdir):
     ]:
         assert os.path.isfile(f"{tmpdir}/{filepath}")
 
+def test_tagfolder_in_src(tmpdir):
+    """
+    If the tag-destination is inside the source-directory, we must ignore it..
+    """
+    tmp = f"{tmpdir}/tagfolder_in_source"
+    shutil.copytree(f"{test_files}/tagfolder_in_source", tmp, symlinks=True)
+
+    for i in [0, 1]:
+        taggo.main(["run", "--nametemplate", "{path.basename} - {path.hierarcy_str}", tmp, tmp + '/tags'])
+
+    assert len(glob.glob(tmp + '/tags/*')) == 1
+
 
 def test_existing_file_dst(tmpdir):
     tmppath = f"{tmpdir}/existing-file"