Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Byte-compilation prevents functioning of control/meta key settings #98

Open
rjhwelsh opened this issue May 24, 2020 · 1 comment
Open

Comments

@rjhwelsh
Copy link

Hi,

If I try byte-compiling my init for xah-fly-keys, it causes the customizations xah-fly-use-meta-key and xah-fly-use-control-key to not be picked up, before loading the xah-fly-keys package.
(And all my control/meta keys are bound up by the xah-fly-keys package.)

As a workaround, I can add ;;; xah-fly-keys-config.el --- -*- no-byte-compile: t -*- to my config file; and everything works fine. Perhaps it's my fault, and I shouldn't try to byte-compile everything ;P.

On the other hand, I was thinking maybe it would be cleaner to package the keybindings into a function, which could be called when the user enables (xah-fly-keys 1) for the first time.
Any thoughts on this?

(PS I am happy to do the work and submit a pull-request, if you think it might be a good idea.)

My current config, for reference, (tested with xah-fly-keys_old_2020-04-18.el).
;;; xah-fly-keys-config.el --- -*- no-byte-compile: t -*-
(setq xah-fly-use-meta-key nil)
(setq xah-fly-use-control-key nil)
(use-package "xah-fly-keys"
:ensure t
:init
(require 'xah-fly-keys)
(xah-fly-keys-set-layout 'colemak)
(xah-fly-keys 1)
)

All the best,
R

@ghost
Copy link

ghost commented May 19, 2021

Is this still happening? I used the following config and it worked:

(use-package xah-fly-keys
  :custom
  (xah-fly-keys-set-layout "dvorak")
  (xah-fly-use-control-key nil)
  (xah-fly-use-meta-key nil)
  :config
  (xah-fly-keys t))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant