Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scaleFactor options #18

Open
ianjennings opened this issue Mar 23, 2021 · 2 comments
Open

Add scaleFactor options #18

ianjennings opened this issue Mar 23, 2021 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ianjennings
Copy link

Mac file sizes are super large due to retina display.

@alexpelan wrote an implementation of scaleFactor for the Swift binary here:
wulkano/Aperture#73

These options will need to make it into index.ts on merge:
https://github.com/wulkano/aperture-node/blob/main/index.js#L42

I'm not familiar with Swift, so I'm having trouble building the binary. Tonight I was able to produce x86_64-apple-macosx/release/Aperture though this doesn't fit the script found in package.json so I'm hesitant to move forward here.

Happy to add the Javascript options if someone can provide the binary.

@sindresorhus sindresorhus added enhancement New feature or request help wanted Extra attention is needed labels Mar 23, 2021
@chrisspiegl
Copy link

chrisspiegl commented Mar 11, 2022

This wold be great to see this added.

I am not sure what is missing here, this PR #20 mentions that it's already implemented but looks like the Node.js stuff is missing? Is this correct?

@chrisspiegl
Copy link

Found a workaround for this issue by using BetterDummy and Virtual Display Monitors in macOS for my Screen Recording needs.

It's not perfect (and needs some setup time if you want to use on your internal display), but it does the job perfectly for me.

My Virtual Screen is setup to be a 1920x1080 HiDPI screen which is a resolution macOS does not really like (or offers) with the internal displays. But this way, I get a 4k image recorded which is a perfect 16x9 that I can include in my video work without it being overly huge on the viewers screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants