Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sequence Backend] UI issue when performing API save after adding a sequence as a backend #3265

Open
ashera96 opened this issue Oct 16, 2024 · 1 comment · May be fixed by wso2/apim-apps#815
Open

[Sequence Backend] UI issue when performing API save after adding a sequence as a backend #3265

ashera96 opened this issue Oct 16, 2024 · 1 comment · May be fixed by wso2/apim-apps#815
Assignees
@Piumal1999
Labels
4.4.0 Affected/APIM-4.4.0 Issues affecting APIM 4.4.0 Component/APIM React-UI Type/Bug

Comments

@ashera96
Copy link

Description

When adding sequence as a backend, and Saving the API, the following success alerts are shown in the UI. We need to fix those and show only a single alert to mention that the API update was successful.

image

Steps to Reproduce

  1. Navigate to the publisher portal and create an API
  2. Click on Endpoints tab and select Sequence Backend option to upload a sequence as the backend
  3. Click Save. Then you should be able to see the above reported alerts.

Affected Component

APIM

Version

4.4.0

Environment Details (with versions)

No response

Relevant Log Output

No response

Related Issues

No response

Suggested Labels

No response
@Piumal1999 Piumal1999 self-assigned this Oct 17, 2024
@Piumal1999
Copy link

Hi @ashera96 @RakhithaRR,

Should we handle error alerts the same way? Currently, there are separate error alerts for sequence backend deletions and updates, similar to the success alert shown in the above screenshot.

Btw, in the current implementation [1], when we update the sequence backend configuration, it makes 4 API calls: 2 to delete the existing sequence backend and 2 to add the new ones. After that, it sets the endpoint_type using the update API endpoint. If any of the first four API calls fail for some reason, wouldn’t that cause a consistency issue?

(Even if all 4 API calls fail, the next API call will still set the endpoint_type as sequence_backend and show a success message. )

image

[1] https://github.com/wso2/apim-apps/blob/5e1357a0c9a08ed5fb962c150bffb1b8fe8492f3/portals/publisher/src/main/webapp/source/src/app/components/Apis/Details/Endpoints/Endpoints.jsx#L219-L269

This was referenced Oct 18, 2024
Merged
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Piumal1999 Piumal1999

Labels
4.4.0 Affected/APIM-4.4.0 Issues affecting APIM 4.4.0 Component/APIM React-UI Type/Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove additional alerts in sequence backend update process Piumal1999/apim-apps
3 participants
@RakhithaRR @Piumal1999 @ashera96