Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle token null scenario when retrieving the token hash from the issuer #2733

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

madurangasiriwardena
Copy link
Member

@madurangasiriwardena madurangasiriwardena commented Feb 24, 2025

Related to the fix in #2732

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.90%. Comparing base (1eeffb6) to head (9c056d6).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...penidconnect/DefaultOIDCClaimsCallbackHandler.java 0.00% 0 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2733   +/-   ##
=========================================
  Coverage     56.90%   56.90%           
- Complexity     8566     8567    +1     
=========================================
  Files           654      654           
  Lines         48425    48425           
  Branches      10252    10252           
=========================================
+ Hits          27556    27557    +1     
  Misses        16967    16967           
+ Partials       3902     3901    -1     
Flag Coverage Δ
unit 39.98% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thumimku
Copy link
Contributor

The flow was working for code grant but not working for password grant. I tested the flow with the fix and its working .

@madurangasiriwardena madurangasiriwardena changed the title Handle token null scenario Handle token null scenario when retrieving the token hash from the issuer Feb 24, 2025
@madurangasiriwardena madurangasiriwardena merged commit acff0aa into master Feb 24, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants