Sending access token through request body to oauth2/userinfo #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o OAuthRequestWrapper to avoid using direct apache HttpServletRequestFilter which doesn't consider content-type with charset.
Migara-Pramod
requested review from
aaujayasena,
Buddhimah,
denuwanthi,
dewniMW,
emswbandara,
janakamarasena and
mefarazath
as code owners
|
|
|
PR builder started |
mefarazath
reviewed
Jan 29, 2021
| @BeforeTest | ||
| public void setUp() throws Exception { | ||
|
|
||
| openIDConnectUserEndpoint = new OpenIDConnectUserEndpoint(); | ||
| paramMap = new MultivaluedHashMap<>(); |
There was a problem hiding this comment.
Can we have a unit test covering the scenario where the access token comes in the body as a form param
mefarazath
approved these changes
Jan 29, 2021
|
PR builder completed |
jenkins-is-staging
approved these changes
Jan 29, 2021
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/520895380
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix for the issue - wso2/product-is#10387