Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Superseded unit in WMDR code table #520

Open
fstuerzl opened this issue Feb 20, 2024 · 0 comments
Open

Bug: Superseded unit in WMDR code table #520

fstuerzl opened this issue Feb 20, 2024 · 0 comments
Assignees
@amilan17
Labels
Bug Something isn't working

Comments

@fstuerzl
Copy link
Member

fstuerzl commented Feb 20, 2024 •
edited
Loading

Details

After the recent implementation of code list changes, I ran our comparison script (OSCAR <-> Codes Registry) again and noticed an entry in the units table, that shouldn’t be there anymore: http://codes.wmo.int/wmdr/unit/mg_m-3_25C
It was superseded by https://codes.wmo.int/wmdr/unit/_mg.m-3 a while ago (see #355).
It is not in the GitHub table https://github.com/wmo-im/wmds/blob/master/tables_en/1-02.csv anymore, but there seems to be a mix up in the superseded table:
unit
Is it possible, that it wasn’t implemented in the codes registry correctly due to these two entries (the second one being the correct one)?
In OSCAR the entry was already superseded during the change in December.

Requestor

@fstuerzl
@fstuerzl fstuerzl added the Bug Something isn't working label Feb 20, 2024
@amilan17 amilan17 mentioned this issue Apr 18, 2024
Closed
@amilan17 amilan17 linked a pull request Apr 23, 2024 that will close this issue
520 bug superseded unit in wmdr code table #530
Closed
amilan17 added a commit that referenced this issue Jul 3, 2024
@amilan17
issue Bug: Superseded unit in WMDR code table #520
09ba33b
@amilan17 amilan17 removed a link to a pull request Jul 3, 2024
520 bug superseded unit in wmdr code table #530
Closed
@amilan17 amilan17 mentioned this issue Jul 3, 2024
Merged
amilan17 added a commit that referenced this issue Aug 20, 2024
@amilan17
issue Bug: Superseded unit in WMDR code table #520 (#540)
e999d1d 
#520
amilan17 added a commit that referenced this issue Nov 7, 2024
@amilan17 @joergklausen @fstuerzl
FT2024-2 WMDS (#541)
c7cf173 
* update branch for issue #391 (#538)

* update branch for issue #391

* Github Action Commit

---------

Co-authored-by: Anna Milan <[email protected]>
Co-authored-by: joergklausen <[email protected]>

* 443 1 01 01 addition of definitions for cloud variables (#537)

* Update 1-01-01.csv

* Update 1-01-01.csv

* Github Action Commit

---------

Co-authored-by: Franziska Stürzl <[email protected]>
Co-authored-by: joergklausen <[email protected]>

* add core and recommended (#544)

* add flash definitions (#545)

#391

* Github Action Commit

* issue Bug: Superseded unit in WMDR code table #520 (#540)

#520

* Update 1-01-01.csv

editorial revision to definition of 507

* Github Action Commit

* Update 1-01-01.csv

editorial

* Github Action Commit

* Update 9-02.csv

editorial

* Revise datapolicy (#546)

* Update 9-02.csv

#475

* Update 9-02.csv

* Update 9-02.csv

re-order

* Update 9-02.csv (#547)

remove comparisons to previous data policies

* Apply suggestions from code review

replace issue numbers with sequential notation numbers

---------

Co-authored-by: Jörg Klausen <[email protected]>
Co-authored-by: joergklausen <[email protected]>
Co-authored-by: Franziska Stürzl <[email protected]>
Co-authored-by: amilan17 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amilan17 amilan17

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amilan17 @fstuerzl