Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] - Use separate checkpoint feature does not work on current versions of Forge (w/ Flux support) #99

Open
CCpt5 opened this issue Sep 13, 2024 · 7 comments
Assignees
Labels
not bug wontfix This will not be worked on

Comments

@CCpt5
Copy link

CCpt5 commented Sep 13, 2024

Hello again!

I'd love to use your extension w/ Flux/Forge to use some of my older Dreambooth trained likeness models to clean up faces on Flux generations. Unfortunately it seems that feature broke on both your extension and adetailer during all the massive updates to Forge the past couple months.

Is there any chance you could try this feature out on your side and if you can replicate perhaps try to come to up w/ a fix? At the moment (as mentioned in this thread on the adetailer issues page) the extension goes through the motions of masking the image and seemingly running SDXL inferencing, but the image remains the same.

If you need any specific information from me lmk. I'm using the latest version of Forge and uddetailer.

Thanks!!

Issue on addetailer page (closed due to inactivity but can confirm it is still an issue w/ that extension as well):

@wkpark wkpark self-assigned this Sep 14, 2024
@wkpark wkpark added the wontfix This will not be worked on label Sep 15, 2024
@wkpark
Copy link
Owner

wkpark commented Sep 15, 2024

hmm..
It seems override_settings feature has been removed by forge itself.

you can compare original process_images() https://github.com/AUTOMATIC1111/stable-diffusion-webui/blob/master/modules/processing.py#L825-L839

and forge's process_images()
https://github.com/lllyasviel/stable-diffusion-webui-forge/blob/main/modules/processing.py#L797-L819

forge abandon the original override_settings feature. override_settings will be simply ignored.
(please see lllyasviel/stable-diffusion-webui-forge@6921420#diff-1fe5b15d29310b37af0c4560da365990f4e6eee7b99bf3f041cfa18ebb11610fL780 )

@wkpark wkpark added the not bug label Sep 15, 2024
@CCpt5
Copy link
Author

CCpt5 commented Sep 15, 2024

Ahh so basically this feature will no longer be possible?

@wkpark
Copy link
Owner

wkpark commented Sep 15, 2024

Ahh so basically this feature will no longer be possible?

override_settings feature is supported by webui.
so It's up to the forge's decision.

@CCpt5
Copy link
Author

CCpt5 commented Sep 16, 2024

Ahh so basically this feature will no longer be possible?

override_settings feature is supported by webui. so It's up to the forge's decision.

Understood. I explained on the open discussion thread about this issue that's on the Forge repo here: lllyasviel/stable-diffusion-webui-forge#976

I'm ok w/ you closing this if there's no workaround. Thx!

@evanheckert
Copy link

So to be clear, this only breaks the ability to use an alternate checkpoint in Forge, but it still works as a good alternative to adetailer for flux in Forge if using the same checkpoint as the base image?

@wkpark
Copy link
Owner

wkpark commented Sep 21, 2024

yes. some basic features will work as expected.

@CCpt5
Copy link
Author

CCpt5 commented Oct 13, 2024

@wkpark There was a new commit to Forge this morning that suggests it restored the override settings. I gave udetailer a try where the 2nd pass is supposed to use an SDXL model to inpaint the face and still didn't see a result, but this may be my error.

Can you confirm whether or not this update -should- fix udetailer so it can once again use a different checkpoint during the second pass? Thanks!

Re:

lllyasviel/stable-diffusion-webui-forge@862c7a5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not bug wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants