Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some settings do not restore on startup #78

Open
jgrubs1 opened this issue Mar 16, 2024 · 1 comment
Open

Some settings do not restore on startup #78

jgrubs1 opened this issue Mar 16, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@jgrubs1
Copy link

jgrubs1 commented Mar 16, 2024

Certain DD settings do not restore after restarting A1111. These include:

  1. Settings for Secondary model. Particularly, this setting: Inpaint B detections > before inpainting A. As a result, even if a secondary model is configured, and default UI settings are saved and appear in the ui-config.json file (as "customscript/ddetailer.py/txt2img/Inpaint B detections/visible": true, "customscript/ddetailer.py/txt2img/Inpaint B detections/value": "before",), in reality the setting does not show up in the UI after restarting A111, and the second model correctly detects but does not inpaint anything (because Inpaint B detections setting is not restored).

  2. Object classification settings are also not restored and do not appear after relaunching A111. I have mentioned that in a comment to this issue: nsfwrecog_v1 censors too much #76 , regardless of whether they are set at a primary or secondary model.

In other words, uddetailer correctly saves its settings, but does not restore some of them. In order to have these settings re-appear (and to start working), one has to select a different model from the list, then re-select the original model. Only then the correct settings will show up.

Here's what I see after restarting A1111:
no-A-B

To have object class "hand" back, and to make the secondary model work, I have to re-select it from the list (switch to another model, switch back to yolo/hand):
must-reload

@wkpark
Copy link
Owner

wkpark commented Mar 18, 2024

thank you for your reporting!

I will look into this issue asap.

@wkpark wkpark self-assigned this Mar 18, 2024
@wkpark wkpark added the bug Something isn't working label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants