Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wise download-rules downloads invalid YML file, for empty rules #30

Open
noisy opened this issue Dec 10, 2018 · 2 comments
Open

wise download-rules downloads invalid YML file, for empty rules #30

noisy opened this issue Dec 10, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@noisy
Copy link
Contributor

noisy commented Dec 10, 2018

The problem

I did:

wise download-rules -a ned ned.yml
cat /home/noisy/.wise/ned.yml

I expected to see:

$ wise download-rules -a ned ned.yml                                                                                                                                        
Downloading rules set by @ned...                                                                                                                                                                                   
Rules saved to file /home/noisy/.wise/ned.yml                                                                                                                                                                      
$ cat /home/noisy/.wise/ned.yml                                                                                                                                                                      

Instead, I saw

$ wise download-rules -a ned ned.yml                                                                                                                                        
Downloading rules set by @ned...                                                                                                                                                                                   
Rules saved to file /home/noisy/.wise/ned.yml                                                                                                                                                                      
$ cat /home/noisy/.wise/ned.yml                                                                                                                                                                      
[]

Version of steem-wise-core: 3.0.6rc-1

Version of nodejs: 10.0.4

@noisy noisy added the bug Something isn't working label Dec 10, 2018
@Jblew Jblew self-assigned this Dec 11, 2018
@noisy noisy unassigned Jblew Dec 14, 2018
@noisy
Copy link
Contributor Author

noisy commented Dec 14, 2018

To be honest, I am not 100% sure, whether [] is incorrect.

Yaml validators says, that this is correct.

@Jblew
Copy link
Member

Jblew commented Dec 14, 2018

This is uncommon, but correct. Yaml supports the flow style next to the Block style. In general, the flow style is very similar to json. It is useful to denote an empty array eg. https://yaml.org/spec/1.2/spec.html#id2790320

So I think, that we can close this issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants